Bug 70195 – IE quirk for percentage size on a table element doesn't work with orthogonal writing modes

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Ojan Vafai]

Created attachment 111170 [details]
test case

Summary: IE quirk for percentage size on a table element doesn't work with orthogonal writing modes

See the test case. I traced our implementation of this quirk back to http://trac.webkit.org/changeset/4316. It's not clear to me from the patch what sites needed this quirk. My preference would be to remove this quirk entirely. Opera and Mozilla don't implement it and IE doesn't restrict this behavior to quirks mode like we do. We should at least restrict this quirk to horizontal writing mode only.

[Ojan Vafai]

Whoops. The comment in the test case is wrong. The 5th and 6th cases should render the same.

[Ojan Vafai]

Created attachment 111171 [details]
Patch

[Dave Hyatt]

Comment on attachment 111171 [details]
Patch

r=me

[Ojan Vafai]

Created attachment 111302 [details]
Patch

[WebKit Review Bot]

Attachment 111302 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ojan Vafai]

Created attachment 111316 [details]
Patch

[WebKit Review Bot]

Attachment 111316 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
From git://git.webkit.org/WebKit
   928c0b6..97d06fb  master     -> origin/master
	M	Source/JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def
	M	Source/JavaScriptCore/ChangeLog
	M	Source/JavaScriptCore/heap/MarkStack.cpp
r97644 = 97d06fbb7bef9a77fa9ed571cc0257fdcb46c87c (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/trunk.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Ojan Vafai]

Created attachment 111318 [details]
Patch

[WebKit Review Bot]

Attachment 111318 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
From git://git.webkit.org/WebKit
   97d06fb..466a1d4  master     -> origin/master
	M	ChangeLog
	M	Source/cmake/OptionsEfl.cmake
	M	Source/cmake/OptionsWinCE.cmake
	M	Source/cmakeconfig.h.cmake
r97645 = 6f53a24aa712b42c281fd95c21c7eb35d0dd1d1b (refs/remotes/trunk)
	M	Source/JavaScriptCore/ChangeLog
	M	Source/JavaScriptCore/heap/HandleStack.cpp
r97646 = 466a1d4cba90e1f8e49868ee3d8ed4149e4b3f43 (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/trunk.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Eric Seidel (no email)]

Comment on attachment 111318 [details]
Patch

Looks sane to me.  If the other major browsers don't support this old Quirk, no reason we should still need to.

[Ojan Vafai]

Committed r104208: <http://trac.webkit.org/changeset/104208>