Bug 70180 - [GTK] GtkAdjustment watcher updates adjustments too lazily
Summary: [GTK] GtkAdjustment watcher updates adjustments too lazily
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Martin Robinson
URL:
Keywords:
Depends on:
Blocks: 68757
  Show dependency tree / graph
 
Reported: 2011-10-15 14:05 PDT by Martin Robinson
Modified: 2011-10-25 09:52 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.41 KB, patch)
2011-10-15 14:11 PDT, Martin Robinson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-10-15 14:05:27 PDT 
The timeout  GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater has a low enough priority that sometimes scrollbars become out of sync with the page contents. I've seen this cause drawing artifacts as well. We just need to boost the priority slightly.
Comment 1 Martin Robinson 2011-10-15 14:11:00 PDT 
Created attachment 111144 [details]
Patch
Comment 2 Carlos Garcia Campos 2011-10-16 23:45:52 PDT 
Comment on attachment 111144 [details]
Patch

LGTM
Comment 3 Gustavo Noronha (kov) 2011-10-24 05:45:33 PDT 
Comment on attachment 111144 [details]
Patch

I hate these priority problems =( I think it makes sense as it is, but just out of curiosity, did you try having it set to something like G_PRIORITY_HIGH_IDLE itself, which would guarantee it's ran before any GTK+ layout is performed?
Comment 4 Martin Robinson 2011-10-25 09:38:33 PDT 
Comment on attachment 111144 [details]
Patch

Landing this now, since I think Alex wants it for the release. To answer kov's question, I'm pretty sure I did test G_PRIORITY_HIGH_IDLE without much luck.
Comment 5 WebKit Review Bot 2011-10-25 09:51:57 PDT 
Comment on attachment 111144 [details]
Patch

Clearing flags on attachment: 111144

Committed r98352: <http://trac.webkit.org/changeset/98352>
Comment 6 WebKit Review Bot 2011-10-25 09:52:02 PDT 
All reviewed patches have been landed.  Closing bug.