Bug 70172 – [Chromium] Implement canvas.toDataURL("image/webp")

Bug 70172 - [Chromium] Implement canvas.toDataURL("image/webp")


Summary:	[Chromium] Implement canvas.toDataURL("image/webp")

Status:	RESOLVED FIXED

Product:	WebKit
Classification:	Unclassified
Component:	Canvas
Version:	528+ (Nightly build)
Platform:	Unspecified Unspecified

Importance:	P2 Normal
Assigned To:	noel gordon

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2011-10-15 01:02 PDT by noel gordon
Modified:	2011-11-13 17:22 PST (History)
CC List:	3 users (show)

See Also:

Attachments
Patch (18.80 KB, patch) 2011-10-15 01:04 PDT, noel gordon	no flags	Details \| Formatted Diff \| Diff
Patch (19.06 KB, patch) 2011-10-16 22:35 PDT, noel gordon	no flags	Details \| Formatted Diff \| Diff
Update ChangeLog. (19.05 KB, patch) 2011-10-19 01:05 PDT, noel gordon	no flags	Details \| Formatted Diff \| Diff
Patch for landing. (19.15 KB, patch) 2011-11-04 00:40 PDT, noel gordon	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description noel gordon 2011-10-15 01:02:14 PDT

[Chromium] Implement canvas.toDataURL("image/webp")

Comment 1 noel gordon 2011-10-15 01:04:59 PDT

Created attachment 111129 [details]
Patch

Comment 2 noel gordon 2011-10-16 22:35:43 PDT

Created attachment 111214 [details]
Patch

Comment 3 noel gordon 2011-10-19 01:05:12 PDT

Created attachment 111573 [details]
Update ChangeLog.

Comment 4 Adam Barth 2011-11-02 21:46:41 PDT

Comment on attachment 111573 [details]
Update ChangeLog.

View in context: https://bugs.webkit.org/attachment.cgi?id=111573&action=review

> Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:391
> +            return "data:,";

Should "data:," be a constant shared by all the uses in this function?

Comment 5 noel gordon 2011-11-03 05:08:14 PDT

Indeed, could be shared yes.  In a future patch, I plan to factor it out and
make this function return a boolean.

Comment 6 noel gordon 2011-11-04 00:40:53 PDT

Created attachment 113629 [details]
Patch for landing.

Comment 7 WebKit Review Bot 2011-11-04 14:14:41 PDT

Comment on attachment 113629 [details]
Patch for landing.

Clearing flags on attachment: 113629

Committed r99319: <http://trac.webkit.org/changeset/99319>

Comment 8 WebKit Review Bot 2011-11-04 14:14:46 PDT

All reviewed patches have been landed.  Closing bug.

Comment 9 noel gordon 2011-11-13 17:22:25 PST

(In reply to comment #5)
> In a future patch, I plan to factor it out and make this function return a boolean.

Bug 71846