WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
70172
[Chromium] Implement canvas.toDataURL("image/webp")
https://bugs.webkit.org/show_bug.cgi?id=70172
Summary
[Chromium] Implement canvas.toDataURL("image/webp")
noel gordon
Reported
2011-10-15 01:02:14 PDT
[Chromium] Implement canvas.toDataURL("image/webp")
Attachments
Patch
(18.80 KB, patch)
2011-10-15 01:04 PDT
,
noel gordon
no flags
Details
Formatted Diff
Diff
Patch
(19.06 KB, patch)
2011-10-16 22:35 PDT
,
noel gordon
no flags
Details
Formatted Diff
Diff
Update ChangeLog.
(19.05 KB, patch)
2011-10-19 01:05 PDT
,
noel gordon
no flags
Details
Formatted Diff
Diff
Patch for landing.
(19.15 KB, patch)
2011-11-04 00:40 PDT
,
noel gordon
no flags
Details
Formatted Diff
Diff
Show Obsolete
(3)
View All
Add attachment
proposed patch, testcase, etc.
noel gordon
Comment 1
2011-10-15 01:04:59 PDT
Created
attachment 111129
[details]
Patch
noel gordon
Comment 2
2011-10-16 22:35:43 PDT
Created
attachment 111214
[details]
Patch
noel gordon
Comment 3
2011-10-19 01:05:12 PDT
Created
attachment 111573
[details]
Update ChangeLog.
Adam Barth
Comment 4
2011-11-02 21:46:41 PDT
Comment on
attachment 111573
[details]
Update ChangeLog. View in context:
https://bugs.webkit.org/attachment.cgi?id=111573&action=review
> Source/WebCore/platform/graphics/skia/ImageBufferSkia.cpp:391 > + return "data:,";
Should "data:," be a constant shared by all the uses in this function?
noel gordon
Comment 5
2011-11-03 05:08:14 PDT
Indeed, could be shared yes. In a future patch, I plan to factor it out and make this function return a boolean.
noel gordon
Comment 6
2011-11-04 00:40:53 PDT
Created
attachment 113629
[details]
Patch for landing.
WebKit Review Bot
Comment 7
2011-11-04 14:14:41 PDT
Comment on
attachment 113629
[details]
Patch for landing. Clearing flags on attachment: 113629 Committed
r99319
: <
http://trac.webkit.org/changeset/99319
>
WebKit Review Bot
Comment 8
2011-11-04 14:14:46 PDT
All reviewed patches have been landed. Closing bug.
noel gordon
Comment 9
2011-11-13 17:22:25 PST
(In reply to
comment #5
)
> In a future patch, I plan to factor it out and make this function return a boolean.
Bug 71846
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug