Bug 70170 - [EFL] Some dirty areas are ignored without repainting.
Summary: [EFL] Some dirty areas are ignored without repainting.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL: http://ie.microsoft.com/testdrive/Gra...
Keywords:
: 70900 (view as bug list)
Depends on: 67112
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-14 23:16 PDT by ChangSeok Oh
Modified: 2011-11-02 00:21 PDT (History)
7 users (show)

See Also:


Attachments
Proposed patch (1.67 KB, patch)
2011-10-27 00:12 PDT, ChangSeok Oh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ChangSeok Oh 2011-10-14 23:16:53 PDT
Dirty area is not update properly while animation with requestAnimationFrame enabled for EFL port.
Visit here http://ie.microsoft.com/testdrive/Graphics/RequestAnimationFrame/Default.html.
Comment 1 ChangSeok Oh 2011-10-27 00:12:19 PDT
Created attachment 112643 [details]
Proposed patch
Comment 2 Ryuan Choi 2011-10-27 02:29:26 PDT
*** Bug 70900 has been marked as a duplicate of this bug. ***
Comment 3 Ryuan Choi 2011-10-27 02:31:06 PDT
Informal r+ on my side.
Comment 4 Raphael Kubo da Costa (:rakuco) 2011-10-27 06:04:49 PDT
Passing "-b single http://ie.microsoft.com/testdrive/Graphics/RequestAnimationFrame/Default.html" to EWebLauncher did not show anything weird while rendering the linked page. Can you describe what was supposed to be seen?
Comment 5 ChangSeok Oh 2011-10-27 07:10:37 PDT
(In reply to comment #4)
> Passing "-b single http://ie.microsoft.com/testdrive/Graphics/RequestAnimationFrame/Default.html" to EWebLauncher did not show anything weird while rendering the linked page. Can you describe what was supposed to be seen?

I guess you missed applying a submitted patch for bug67112 before. This will enable requestAnimationFrame JS API so that you can see 2 clocks and some changing numbers.
Comment 6 KwangHyuk 2011-10-30 18:25:48 PDT
> Passing "-b single http://ie.microsoft.com/testdrive/Graphics/RequestAnimationFrame/Default.html" to EWebLauncher did not show anything weird while rendering the linked page. Can you describe what was supposed to be seen?

Hi, Kubo,

I think that you can notice the reason why this patch is reasonable if you check www.daum.net.

Just go to www.daum.net and scroll down 2 times. and then click daum title image on top of the left cornor of website without this patch first.

And finally use this patch for the same checking.
Comment 7 KwangHyuk 2011-10-30 18:26:07 PDT
LGTM.
Comment 8 Raphael Kubo da Costa (:rakuco) 2011-10-31 06:13:34 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > Passing "-b single http://ie.microsoft.com/testdrive/Graphics/RequestAnimationFrame/Default.html" to EWebLauncher did not show anything weird while rendering the linked page. Can you describe what was supposed to be seen?
> 
> I guess you missed applying a submitted patch for bug67112 before. This will enable requestAnimationFrame JS API so that you can see 2 clocks and some changing numbers.

Oops, thanks for the pointer. From what I see, the patch makes callback counters actually work, right?
Comment 9 Raphael Kubo da Costa (:rakuco) 2011-10-31 06:14:16 PDT
(In reply to comment #8)
> Oops, thanks for the pointer. From what I see, the patch makes callback counters actually work, right?

BTW, if that's the issue, doesn't it need to be fixed in the tiled backing store too?
Comment 10 KwangHyuk 2011-10-31 06:31:30 PDT
(In reply to comment #9)
> (In reply to comment #8)
> > Oops, thanks for the pointer. From what I see, the patch makes callback counters actually work, right?
> 
> BTW, if that's the issue, doesn't it need to be fixed in the tiled backing store too?

You are right.
Tiled view also requires it.
Comment 11 Raphael Kubo da Costa (:rakuco) 2011-10-31 06:36:27 PDT
(In reply to comment #10)
> (In reply to comment #9)
> > (In reply to comment #8)
> > > Oops, thanks for the pointer. From what I see, the patch makes callback counters actually work, right?
> > 
> > BTW, if that's the issue, doesn't it need to be fixed in the tiled backing store too?
> 
> You are right.
> Tiled view also requires it.

OK, so if this is the issue that this patch fixes, you have my informal r+, even though it'd be better to fix both backing stores in a single patch.
Comment 12 Eric Seidel (no email) 2011-11-01 23:12:33 PDT
Comment on attachment 112643 [details]
Proposed patch

rubber-stamp.  This really should be tested, but I don't think EFL has DumpREnderTree yet... Does it?  If so, we could use repaint tests.
Comment 13 WebKit Review Bot 2011-11-02 00:21:43 PDT
Comment on attachment 112643 [details]
Proposed patch

Clearing flags on attachment: 112643

Committed r99041: <http://trac.webkit.org/changeset/99041>
Comment 14 WebKit Review Bot 2011-11-02 00:21:48 PDT
All reviewed patches have been landed.  Closing bug.