Bug 70163 - Add getConstructData to the MethodTable
Summary: Add getConstructData to the MethodTable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks: 67690
  Show dependency tree / graph
 
Reported: 2011-10-14 17:53 PDT by Mark Hahnenberg
Modified: 2011-10-19 16:26 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.33 KB, patch)
2011-10-17 15:47 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Patch (5.43 KB, patch)
2011-10-18 10:57 PDT, Mark Hahnenberg 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2011-10-14 17:53:46 PDT 
We now need to add getConstructData to the MethodTable in ClassInfo in preparation for removing the virtual version of getConstructData.
Comment 1 Mark Hahnenberg 2011-10-17 15:47:01 PDT 
Created attachment 111335 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-17 15:48:58 PDT 
Attachment 111335 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
Current branch master is up to date.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Mark Hahnenberg 2011-10-18 10:57:12 PDT 
Created attachment 111470 [details]
Patch
Comment 4 Geoffrey Garen 2011-10-19 14:31:51 PDT 
Comment on attachment 111470 [details]
Patch

r=me
Comment 5 WebKit Review Bot 2011-10-19 16:26:55 PDT 
Comment on attachment 111470 [details]
Patch

Clearing flags on attachment: 111470

Committed r97892: <http://trac.webkit.org/changeset/97892>
Comment 6 WebKit Review Bot 2011-10-19 16:26:59 PDT 
All reviewed patches have been landed.  Closing bug.