Bug 70157 – FunctionExecutable should expose the ability to create unattached FunctionCodeBlocks

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Inlining requires being able to create a CodeBlock that is populated with bytecode for any callee that constitutes an inlining candidate.  Currently this is not possible without a non-trivial amount of code duplication.  Since FunctionExecutable already has the code for creating FunctionCodeBlocks that are populated with bytecode (in fact it has this functionality twice), this should simply be exposed as a method.  This will also provide an opportunity to reduce some of the redundant code in FunctionExecutable.

[Filip Pizlo]

Created attachment 111107 [details]
the patch

[WebKit Review Bot]

Attachment 111107 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/runtime/Executable.h:465:  The parameter name "exec" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/runtime/Executable.h:465:  The parameter name "scopeChainNode" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/runtime/Executable.h:465:  The parameter name "compilationKind" adds no information, so it should be removed.  [readability/parameter_name] [5]
Source/JavaScriptCore/runtime/Executable.h:465:  The parameter name "kind" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Created attachment 111108 [details]
the patch - fix style

[Geoffrey Garen]

Comment on attachment 111108 [details]
the patch - fix style

View in context: https://bugs.webkit.org/attachment.cgi?id=111108&action=review

r=me

> Source/JavaScriptCore/runtime/Executable.cpp:416
> +        return PassOwnPtr<FunctionCodeBlock>();

I think you can just return nullptr here.

> Source/JavaScriptCore/runtime/Executable.cpp:427
> +    result = adoptPtr(new FunctionCodeBlock(this, FunctionCode, globalObject, source().provider(), source().startOffset(), specializationKind == CodeForConstruct, PassOwnPtr<FunctionCodeBlock>()));

nullptr, or maybe just make that the default function argument.

> Source/JavaScriptCore/runtime/Executable.cpp:432
> +        return PassOwnPtr<FunctionCodeBlock>();

nullptr

[Filip Pizlo]

Landed in r97564.