RESOLVED FIXED 70154
watchlist: Add a validation check for the email names in the list. 
https://bugs.webkit.org/show_bug.cgi?id=70154
Summary watchlist: Add a validation check for the email names in the list.
David Levin
Reported 2011-10-14 15:53:47 PDT
watchlist: Add a validation check for the email names in the list.
Attachments
Patch (5.03 KB, patch)
2011-10-14 15:58 PDT, David Levin 		abarth: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2011-10-14 15:58:41 PDT
Created attachment 111102 [details] Patch
Adam Barth
Comment 2 2011-10-14 16:01:49 PDT
Comment on attachment 111102 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111102&action=review > Tools/Scripts/webkitpy/common/watchlist/watchlistparser.py:137 > + raise Exception("The email alias %s which is in the watchlist is not listed as a contributor in committers.py" % email) I see that we've already using Exception in this class, but it's usually good form to use a subclass of exception so that folks can catch these parse errors without catching all manner of exceptions. (Just a general note. Nothing that needs to be addressed now.)
David Levin
Comment 3 2011-10-14 16:12:37 PDT
Committed as http://trac.webkit.org/changeset/97530
Note You need to log in before you can comment on or make changes to this bug.