Bug 70152 – Widget window coordinate functions should use root view coordinate functions

• Status: RESOLVED
• Resolution: WONTFIX
• Component: Frames

[Jeff Miller]

Follow-up to bug 69963.

Simon Fraser suggests:

> Source/WebCore/platform/Widget.cpp:106
> +IntRect Widget::convertFromRootView(const IntRect& rootRect) const
> +{
> +    if (const ScrollView* parentScrollView = parent()) {
> +        IntRect parentRect = parentScrollView->convertFromRootView(rootRect);
> +        return convertFromContainingView(parentRect);
> +    }
> +    return rootRect;
> +}
> +
> +IntRect Widget::convertToRootView(const IntRect& localRect) const
> +{
> +    if (const ScrollView* parentScrollView = parent()) {
> +        IntRect parentRect = convertToContainingView(localRect);
> +        return parentScrollView->convertToRootView(parentRect);
> +    }
> +    return localRect;
> +}
> +
> +IntPoint Widget::convertFromRootView(const IntPoint& rootPoint) const
> +{
> +    if (const ScrollView* parentScrollView = parent()) {
> +        IntPoint parentPoint = parentScrollView->convertFromRootView(rootPoint);
> +        return convertFromContainingView(parentPoint);
> +    }
> +    return rootPoint;
> +}
> +
> +IntPoint Widget::convertToRootView(const IntPoint& localPoint) const
> +{
> +    if (const ScrollView* parentScrollView = parent()) {
> +        IntPoint parentPoint = convertToContainingView(localPoint);
> +        return parentScrollView->convertToRootView(parentPoint);
> +    }
> +    return localPoint;
> +}

How about calling these from the existing toWindow/fromWindow calls?

[Jeff Miller]

Created attachment 111307 [details]
Patch

[WebKit Review Bot]

Attachment 111307 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2

Updating OpenSource
From git://git.webkit.org/WebKit
   abfc01f..284a880  master     -> origin/master
	M	Source/WebKit/mac/ChangeLog
	M	Source/WebKit/mac/WebView/WebView.mm
	M	Source/WebCore/WebCore.exp.in
	M	Source/WebCore/ChangeLog
	M	Source/WebCore/page/Page.h
	M	Source/WebCore/page/Page.cpp
	M	Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp
	M	Source/WebKit2/ChangeLog
r97640 = 284a880fb02564497ff4d4c705cfc8d3ca46285e (refs/remotes/trunk)
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/trunk.
Updating chromium port dependencies using gclient...
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Re-trying 'depot_tools/gclient sync'
Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
Re-trying 'depot_tools/gclient sync'
No such file or directory at Tools/Scripts/update-webkit line 104.


If any of these errors are false positives, please file a bug against check-webkit-style.

[Jeff Miller]

(In reply to comment #2)
> Attachment 111307 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2
> 
> Updating OpenSource
> From git://git.webkit.org/WebKit
>    abfc01f..284a880  master     -> origin/master
>     M    Source/WebKit/mac/ChangeLog
>     M    Source/WebKit/mac/WebView/WebView.mm
>     M    Source/WebCore/WebCore.exp.in
>     M    Source/WebCore/ChangeLog
>     M    Source/WebCore/page/Page.h
>     M    Source/WebCore/page/Page.cpp
>     M    Source/WebKit2/WebProcess/WebPage/DrawingAreaImpl.cpp
>     M    Source/WebKit2/ChangeLog
> r97640 = 284a880fb02564497ff4d4c705cfc8d3ca46285e (refs/remotes/trunk)
> First, rewinding head to replay your work on top of it...
> Fast-forwarded master to refs/remotes/trunk.
> Updating chromium port dependencies using gclient...
> Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
> Re-trying 'depot_tools/gclient sync'
> Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
> Re-trying 'depot_tools/gclient sync'
> Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again.
> Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107.
> Re-trying 'depot_tools/gclient sync'
> No such file or directory at Tools/Scripts/update-webkit line 104.
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

This patch passed check-webkit-style locally when I used "webkit-patch upload". This looks like a temporary failure and not an actual bug in check-webkit-style, so I'm not going to file a bug.

[Jeff Miller]

Committed r97641: <http://trac.webkit.org/changeset/97641>

[Ryosuke Niwa]

Reopen the bug because it was rolled out in http://trac.webkit.org/changeset/97688.

[Jeff Miller]

Ryosuke Niwa notes:

"This patch appears to have caused 15+ tests to fail on Snow Leopard:
http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r97655%20(2609)/results.html

Tests passed on r97640 but fail on r97646."

I will ensure these tests pass before landing a new patch.

[Jeff Miller]

I verified that my original patch does cause these test failures.

[Jeff Miller]

After further investigation, it would be sub-optimal to try to leverage the new root view coordinate functions when dealing with window coordinates. Since convertFromRootToContainingWindow() and convertFromContainingWindowToRoot() require the root widget, so we would have to walk up the view hierarchy twice.

The test failures were being caused by the fact that I was passing the non-root widget to these two member functions, which led to incorrect results on the Mac.

Closing as WONTFIX.