[EFL] Plug ImageDiff/DumpRenderTree on CMake build system
Created attachment 111073 [details] Patch
Patrick, would you mind informally reviewing these changes?
Comment on attachment 111073 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111073&action=review > Tools/DumpRenderTree/efl/CMakeLists.txt:87 > +SET(DumpRenderTree_LINK_FLAGS ${EWebLauncher_LINK_FLAGS}) I wonder if setting this is really necessary; if so, its value shouldn't depend on EWebLauncher.
Comment on attachment 111073 [details] Patch Attachment 111073 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10068456
(In reply to comment #4) > (From update of attachment 111073 [details]) > Attachment 111073 [details] did not pass efl-ews (efl): > Output: http://queues.webkit.org/results/10068456 Hmm, you either need to fix the ewk_view_page_scale calls in DRT or wait for bug 70078 to land.
Comment on attachment 111073 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111073&action=review > Tools/CMakeListsEfl.txt:62 > +INCLUDE_IF_EXISTS(${TOOLS_DIR}/DumpRenderTree/${PORT_LOWERCASE}/CMakeLists.txt) if you put it into the CMakeListEfl.txt you can use "efl" directly. Otherwise this should do into the "platform independet" CMakeLists.txt > Tools/DumpRenderTree/efl/CMakeLists.txt:90 > + LIST(APPEND DumpRenderTree_INCLUDE_DIRECTORIES 4 space indentation
Created attachment 111291 [details] Patch
Attachment 111291 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 111291 [details] Patch Attachment 111291 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10089436
Comment on attachment 111291 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111291&action=review > Tools/DumpRenderTree/efl/CMakeLists.txt:87 > +SET(DumpRenderTree_LINK_FLAGS ${EWebLauncher_LINK_FLAGS}) My previous comment still applies.
(In reply to comment #10) > > My previous comment still applies. > That's why this bug depends on 70078. :)
(In reply to comment #11) > (In reply to comment #10) > > > > My previous comment still applies. > > > > That's why this bug depends on 70078. :) Not that comment, but rather the one about DRT's CMakeLists.txt mentioning EWebLauncher variables :P
Created attachment 111300 [details] Patch
I'm clearly sleeping. :) Third time is the charm.
Attachment 111300 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource From git://git.webkit.org/WebKit f85897f..a24babb master -> origin/master Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 111300 [details] Patch Attachment 111300 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10107029
Build problem has been fixed in r97976: <http://trac.webkit.org/changeset/97976>
Comment on attachment 111300 [details] Patch The build problem is said to be fixed, and the change looks correct to me, so r=me.
Comment on attachment 111300 [details] Patch Clearing flags on attachment: 111300 Committed r97992: <http://trac.webkit.org/changeset/97992>
All reviewed patches have been landed. Closing bug.