WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
70141
[Qt][WK2] WebPreferences are impossible to use in QML.
https://bugs.webkit.org/show_bug.cgi?id=70141
Summary
[Qt][WK2] WebPreferences are impossible to use in QML.
Alexis Menard (darktears)
Reported
2011-10-14 14:06:23 PDT
[Qt][WK2] WebPreferences are impossible to use in QML.
Attachments
Patch
(47.61 KB, patch)
2011-10-14 14:08 PDT
,
Alexis Menard (darktears)
no flags
Details
Formatted Diff
Diff
Patch
(47.79 KB, patch)
2011-10-17 05:14 PDT
,
Alexis Menard (darktears)
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1
2011-10-14 14:08:46 PDT
Created
attachment 111071
[details]
Patch
Kenneth Rohde Christiansen
Comment 2
2011-10-15 06:53:24 PDT
Comment on
attachment 111071
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=111071&action=review
Some nits
> Source/WebKit2/ChangeLog:8 > + Make possible to use qwkpreferences in QML. I renamed it
Make *it*. Don't use I. Renamed it to follow our new style regarding class names.
> Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp:301 > + > +
Double newline
> Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:60 > + Q_PROPERTY(QWebPreferences* preferences READ preferences CONSTANT FINAL)
is preferences the right word to use in QML or should it be settings?
> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:29 > + > +
im not sure we use double newlines here
> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:62 > +void QWebPreferencesPrivate::setAttribute(QWebPreferencesPrivate::WebAttribute attr, bool on)
I would have used "enable" and not "on".
> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:94 > + > +
double newline
> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:153 > + > +
again!
> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:171 > +int QWebPreferencesPrivate::fontSize(QWebPreferencesPrivate::FontSize type) const
unsigned? Can we have negative sizes? Wha? FontSize type? :-) s/FontSize/FontSizeType/ ? Kind?
> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:251 > +bool QWebPreferences::XSSAuditingEnabled() const
xssAuditing...
> Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:355 > +void QWebPreferences::setMinimumFontSize(int size)
In the future we need someting like this per column width (-webkit-text-adjust)
> Source/WebKit2/UIProcess/API/qt/qwebpreferences.h:21 > +#ifndef QWEBREFERENCES_H > +#define QWEBPREFERENCES_H
Something is wrong here! Misses P!
Alexis Menard (darktears)
Comment 3
2011-10-17 05:10:42 PDT
(In reply to
comment #2
)
> (From update of
attachment 111071
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=111071&action=review
> > Some nits > > > Source/WebKit2/ChangeLog:8 > > + Make possible to use qwkpreferences in QML. I renamed it > > Make *it*. Don't use I. Renamed it to follow our new style regarding class names. > > > Source/WebKit2/UIProcess/API/qt/qdesktopwebview.cpp:301 > > + > > + > > Double newline > > > Source/WebKit2/UIProcess/API/qt/qdesktopwebview.h:60 > > + Q_PROPERTY(QWebPreferences* preferences READ preferences CONSTANT FINAL) > > is preferences the right word to use in QML or should it be settings?
I don't have a strong opinion here.
> > > Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:29 > > + > > + > > im not sure we use double newlines here > > > Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:62 > > +void QWebPreferencesPrivate::setAttribute(QWebPreferencesPrivate::WebAttribute attr, bool on) > > I would have used "enable" and not "on". > > > Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:94 > > + > > + > > double newline > > > Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:153 > > + > > + > > again! > > > Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:171 > > +int QWebPreferencesPrivate::fontSize(QWebPreferencesPrivate::FontSize type) const > > unsigned? Can we have negative sizes? > > Wha? FontSize type? :-) s/FontSize/FontSizeType/ ? Kind? > > > Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:251 > > +bool QWebPreferences::XSSAuditingEnabled() const > > xssAuditing... > > > Source/WebKit2/UIProcess/API/qt/qwebpreferences.cpp:355 > > +void QWebPreferences::setMinimumFontSize(int size) > > In the future we need someting like this per column width (-webkit-text-adjust) > > > Source/WebKit2/UIProcess/API/qt/qwebpreferences.h:21 > > +#ifndef QWEBREFERENCES_H > > +#define QWEBPREFERENCES_H > > Something is wrong here! Misses P!
Alexis Menard (darktears)
Comment 4
2011-10-17 05:14:15 PDT
Created
attachment 111246
[details]
Patch
Kenneth Rohde Christiansen
Comment 5
2011-10-17 05:39:52 PDT
Comment on
attachment 111246
[details]
Patch Don't we want the preferences in experimental so far?
Alexis Menard (darktears)
Comment 6
2011-10-17 06:04:12 PDT
(In reply to
comment #5
)
> (From update of
attachment 111246
[details]
) > Don't we want the preferences in experimental so far?
Well I cleaned the flags and let the one that I feel "mandatory" Of course WebGL, DeveloperExtras, and whatever will go in the experimental.
WebKit Review Bot
Comment 7
2011-10-18 05:28:34 PDT
Comment on
attachment 111246
[details]
Patch Clearing flags on attachment: 111246 Committed
r97740
: <
http://trac.webkit.org/changeset/97740
>
WebKit Review Bot
Comment 8
2011-10-18 05:28:39 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug