Bug 70131 - [Qt] Enable fullscreen api on Qt
Summary: [Qt] Enable fullscreen api on Qt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chang Shu
URL:
Keywords:
Depends on:
Blocks: 70111 70132
  Show dependency treegraph
 
Reported: 2011-10-14 12:12 PDT by Chang Shu
Modified: 2011-10-19 06:35 PDT (History)
4 users (show)

See Also:


Attachments
patch 1 (5.26 KB, patch)
2011-10-14 12:22 PDT, Chang Shu
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chang Shu 2011-10-14 12:12:42 PDT
The feature was partially compiled because of flaw in features.pri.
Comment 1 Chang Shu 2011-10-14 12:22:00 PDT
Created attachment 111048 [details]
patch 1
Comment 2 WebKit Review Bot 2011-10-14 15:16:54 PDT
Comment on attachment 111048 [details]
patch 1

Clearing flags on attachment: 111048

Committed r97518: <http://trac.webkit.org/changeset/97518>
Comment 3 WebKit Review Bot 2011-10-14 15:16:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Simon Hausmann 2011-10-19 05:07:42 PDT
Hmm, why do we enable this compile flag when we don't actually implement support for it?
Comment 5 Chang Shu 2011-10-19 06:02:21 PDT
(In reply to comment #4)
> Hmm, why do we enable this compile flag when we don't actually implement support for it?

Before the patch, the flag was partially enabled: ENABLE_FULLSCREEN_API was set to 1 but FEATURE_DEFINES_JAVASCRIPT was not set properly. It looked more like a bug to me than something did intentionally.
We should either remove them completely or finish the rest of the support.
Comment 6 Simon Hausmann 2011-10-19 06:07:58 PDT
I think your patch was good because it fixed that inconsistency (between the build flags and the idl generator defines). But perhaps we should change the default to be false. What do you think?
Comment 7 Chang Shu 2011-10-19 06:35:01 PDT
(In reply to comment #6)
> I think your patch was good because it fixed that inconsistency (between the build flags and the idl generator defines). But perhaps we should change the default to be false. What do you think?

That makes sense. I may not be able to continue this effort in the short term. I will provide a patch to disable them.