Bug 70113 - CachedResourceClient types should be ASSERTed, rather than checked
Summary: CachedResourceClient types should be ASSERTed, rather than checked
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-14 09:51 PDT by Nate Chapin
Modified: 2011-10-14 12:31 PDT (History)
4 users (show)

See Also:


Attachments
patch (4.27 KB, patch)
2011-10-14 09:53 PDT, Nate Chapin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2011-10-14 09:51:47 PDT
If there are CachedResourceClient type mismatches in CachedResourceClientWalker or the CachedResource subclasses, it's an error on our part, so we should assert.

See https://bugs.webkit.org/show_bug.cgi?id=69877 for the initial discussion.
Comment 1 Nate Chapin 2011-10-14 09:53:58 PDT
Created attachment 111024 [details]
patch
Comment 2 WebKit Review Bot 2011-10-14 12:31:05 PDT
Comment on attachment 111024 [details]
patch

Clearing flags on attachment: 111024

Committed r97491: <http://trac.webkit.org/changeset/97491>
Comment 3 WebKit Review Bot 2011-10-14 12:31:10 PDT
All reviewed patches have been landed.  Closing bug.