Bug 70109 – Stricter management of WebKitCSSKeyframeRules.

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Andreas Kling]

WebKitCSSKeyframesRule should only ever manage WebKitCSSKeyframeRule rules, so let's be a bit more strict about this.

[Andreas Kling]

Created attachment 111015 [details]
Proposed patch

[WebKit Review Bot]

Attachment 111015 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Andreas Kling]

(In reply to comment #2)
> Attachment 111015 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
> 
> Source/WebCore/ChangeLog:3:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
> Total errors found: 1 in 4 files

D'oh, I has the dumb.

[Antti Koivisto]

Comment on attachment 111015 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=111015&action=review

r=me, with one change

> Source/WebCore/css/StyleBase.h:-55
> -        virtual bool isKeyframeRule() const { return false; }

Please keep this so you can assert before casting.

> Source/WebCore/css/WebKitCSSKeyframesRule.cpp:80
> +    return static_cast<const WebKitCSSKeyframeRule*>(m_lstCSSRules->item(index));

assert here.

[Andreas Kling]

Committed r97468: <http://trac.webkit.org/changeset/97468>