Bug 70105 - Web Inspector: WebProcess crashes hard when inspecting elements with border-images applied
Summary: Web Inspector: WebProcess crashes hard when inspecting elements with border-i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Simon Fraser (smfr)
URL: http://jsfiddle.net/fermion/wjqNh/3/
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-10-14 05:49 PDT by Rob Sterner
Modified: 2011-10-17 09:14 PDT (History)
14 users (show)

See Also:


Attachments
OS X Console output when the problem occurs (42.82 KB, text/plain)
2011-10-14 07:37 PDT, Rob Sterner
no flags Details
Patch (10.02 KB, patch)
2011-10-14 13:49 PDT, Simon Fraser (smfr)
hyatt: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Sterner 2011-10-14 05:49:35 PDT
I've set up an example fiddle (http://jsfiddle.net/fermion/wjqNh/2/) that demonstrates what I've been seeing for a few weeks now.  This occurs in the current Webkit nightly and Chrome dev. channel browsers.

To reproduce:

1) visit the fiddle in Webkit nightly
2) open up DOM inspector and attempt to inspect styles on the <a> tags in the "Result"  pane
3) BOOM

I've attached a trace from OS X's Console related to the event.  Also notice the display, the link text isn't formatted correctly.  In Webkit:

http://p.fermion.us/3A1j0t1c1s1f3T3W3x2T

in Safari 5.1.1:

http://p.fermion.us/3X0A2g283i0r0K2P1u1Y

If I remove applied border-image and -webkit-border-image tags it's fine.  If I set top/left/right/bottom values to 0 as in:

http://jsfiddle.net/fermion/8DCEh/1/

you can inspect the <a> without issue.  Furthermore, setting all but one of top/left/right/bottom to be a non-zero value as in:

http://jsfiddle.net/fermion/Epr2A/1/

is also fine.  It seems that setting all of top/left/right/bottom to non-zero values triggers the crash.
Comment 1 Andreas Kling 2011-10-14 06:27:23 PDT
Reproduced on ToT. Looks like CSSBorderImageSliceValue::cssText() is crashing because m_slices is null.
Comment 2 Rob Sterner 2011-10-14 07:37:21 PDT
Created attachment 111013 [details]
OS X Console output when the problem occurs

Sorry, I thought I'd attached this originally!
Comment 3 Simon Fraser (smfr) 2011-10-14 09:08:59 PDT
<rdar://problem/10260690>
Comment 4 Simon Fraser (smfr) 2011-10-14 13:49:43 PDT
Created attachment 111068 [details]
Patch
Comment 5 Dave Hyatt 2011-10-14 13:51:28 PDT
Comment on attachment 111068 [details]
Patch

r=me
Comment 6 Simon Fraser (smfr) 2011-10-14 13:57:05 PDT
http://trac.webkit.org/changeset/97502
Comment 7 Rob Sterner 2011-10-15 08:04:46 PDT
I'm curious if I should file a different bug for the apparent rendering issue here, too.  This is a page using the example styles from the jsfiddle links and more, notice the lack of fill behind the "button" text:

http://p.fermion.us/3s2C2C1N1i2o0x162X2N

Here's the same menu in Safari 5.1.1

http://p.fermion.us/0W2m40080x1Z243Z2C2g

I'm more than happy to file another issue if that's what should happen.

Thanks!
Comment 8 Simon Fraser (smfr) 2011-10-17 08:44:15 PDT
I believe that's because we now support unprefixed border-image, and you left 'fill' off of your border-image style.
Comment 9 Rob Sterner 2011-10-17 09:14:58 PDT
(In reply to comment #8)
> I believe that's because we now support unprefixed border-image, and you left 'fill' off of your border-image style.

Got to love PEBKAC errors.  Thanks for the tip Simon!