1. -webkit-flow-from is now a property instead of being an addition to content property. 2. -webkit-flow-from takes an identifier instead of string.
Created attachment 111028 [details] Patch
Comment on attachment 111028 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=111028&action=review > Source/WebCore/css/CSSStyleSelector.cpp:3426 > + if (isInherit) { > + m_style->setRegionThread(nullAtom); > + return; This is wrong. Any reason why you can't just use the composite macro that handles both inherit and initial?
Created attachment 111281 [details] Patch 2
Attachment 111281 [details] did not pass style-queue: Failed to run "['Tools/Scripts/update-webkit', '--chromium']" exit_code: 2 Updating OpenSource Current branch master is up to date. Updating chromium port dependencies using gclient... Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Re-trying 'depot_tools/gclient sync' Error: Can't switch the checkout to http://v8.googlecode.com/svn/branches/3.6@9637; UUID don't match and there is local changes in /mnt/git/webkit-style-queue/Source/WebKit/chromium/v8. Delete the directory and try again. Error: 'depot_tools/gclient sync' failed 3 tries and returned 256 at Tools/Scripts/update-webkit-chromium line 107. Re-trying 'depot_tools/gclient sync' No such file or directory at Tools/Scripts/update-webkit line 104. If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 111281 [details] Patch 2 r=me
Comment on attachment 111281 [details] Patch 2 Clearing flags on attachment: 111281 Committed r97701: <http://trac.webkit.org/changeset/97701>
All reviewed patches have been landed. Closing bug.
This patch appears to have caused 3 printing tests to crash: http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r97702%20(2612)/results.html
(In reply to comment #8) > This patch appears to have caused 3 printing tests to crash: > http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r97702%20(2612)/results.html Taking a look.
(In reply to comment #9) > (In reply to comment #8) > > This patch appears to have caused 3 printing tests to crash: > > http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r97702%20(2612)/results.html > > Taking a look. Oops, this was a false alarm. It's due to r97638.
(In reply to comment #10) > (In reply to comment #9) > > (In reply to comment #8) > > > This patch appears to have caused 3 printing tests to crash: > > > http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r97702%20(2612)/results.html > > > > Taking a look. > > Oops, this was a false alarm. It's due to r97638. Thanks for sharing the information.