RESOLVED FIXED 70100
Merge StyleList into StyleSheet. 
https://bugs.webkit.org/show_bug.cgi?id=70100
Summary Merge StyleList into StyleSheet.
Andreas Kling
Reported 2011-10-14 05:12:41 PDT
StyleSheet is the only subclass of StyleList. We should merge its functionality into StyleSheet.
Attachments
Proposed patch (18.01 KB, patch)
2011-10-14 05:16 PDT, Andreas Kling 		koivisto: review+
kling: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2011-10-14 05:16:28 PDT
Created attachment 110996 [details] Proposed patch
Antti Koivisto
Comment 2 2011-10-14 05:19:26 PDT
Comment on attachment 110996 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=110996&action=review r=me > Source/WebCore/bindings/js/JSCSSRuleListCustom.cpp:-43 > - if (StyleList* styleList = jsCSSRuleList->impl()->styleList()) The variable should be renamed too.
Antti Koivisto
Comment 3 2011-10-14 05:20:46 PDT
Comment on attachment 110996 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=110996&action=review > Source/WebCore/bindings/js/JSCSSRuleListCustom.cpp:43 > - if (StyleList* styleList = jsCSSRuleList->impl()->styleList()) > + if (StyleSheet* styleList = jsCSSRuleList->impl()->styleSheet()) This variable
Gyuyoung Kim
Comment 4 2011-10-14 05:21:53 PDT
Comment on attachment 110996 [details] Proposed patch Attachment 110996 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10062510
WebKit Review Bot
Comment 5 2011-10-14 05:22:28 PDT
Comment on attachment 110996 [details] Proposed patch Attachment 110996 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10066504
Early Warning System Bot
Comment 6 2011-10-14 05:24:29 PDT
Comment on attachment 110996 [details] Proposed patch Attachment 110996 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10054520
Andreas Kling
Comment 7 2011-10-14 05:47:12 PDT
Committed r97460: <http://trac.webkit.org/changeset/97460>
Note You need to log in before you can comment on or make changes to this bug.