Bug 70100 - Merge StyleList into StyleSheet.
Summary: Merge StyleList into StyleSheet.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-14 05:12 PDT by Andreas Kling
Modified: 2011-10-14 05:47 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch (18.01 KB, patch)
2011-10-14 05:16 PDT, Andreas Kling 		koivisto: review+
kling: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2011-10-14 05:12:41 PDT 
StyleSheet is the only subclass of StyleList. We should merge its functionality into StyleSheet.
Comment 1 Andreas Kling 2011-10-14 05:16:28 PDT 
Created attachment 110996 [details]
Proposed patch
Comment 2 Antti Koivisto 2011-10-14 05:19:26 PDT 
Comment on attachment 110996 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110996&action=review

r=me

> Source/WebCore/bindings/js/JSCSSRuleListCustom.cpp:-43
> -    if (StyleList* styleList = jsCSSRuleList->impl()->styleList())

The variable should be renamed too.
Comment 3 Antti Koivisto 2011-10-14 05:20:46 PDT 
Comment on attachment 110996 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110996&action=review

> Source/WebCore/bindings/js/JSCSSRuleListCustom.cpp:43
> -    if (StyleList* styleList = jsCSSRuleList->impl()->styleList())
> +    if (StyleSheet* styleList = jsCSSRuleList->impl()->styleSheet())

This variable
Comment 4 Gyuyoung Kim 2011-10-14 05:21:53 PDT 
Comment on attachment 110996 [details]
Proposed patch

Attachment 110996 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/10062510
Comment 5 WebKit Review Bot 2011-10-14 05:22:28 PDT 
Comment on attachment 110996 [details]
Proposed patch

Attachment 110996 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10066504
Comment 6 Early Warning System Bot 2011-10-14 05:24:29 PDT 
Comment on attachment 110996 [details]
Proposed patch

Attachment 110996 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/10054520
Comment 7 Andreas Kling 2011-10-14 05:47:12 PDT 
Committed r97460: <http://trac.webkit.org/changeset/97460>