Bug 70091 - [EFL] Use EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks instead of EINA_SAFETY_ON_FALSE_RETURN_VAL
Summary: [EFL] Use EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks instead of EINA_SAFE...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-13 23:08 PDT by Grzegorz Czajkowski
Modified: 2011-11-15 03:03 PST (History)
5 users (show)

See Also:

Attachments
proposed patch (2.83 KB, patch)
2011-10-13 23:09 PDT, Grzegorz Czajkowski 		no flags Details | Formatted Diff | Diff
updated patch to current head (2.99 KB, patch)
2011-10-14 03:20 PDT, Grzegorz Czajkowski 		no flags Details | Formatted Diff | Diff
updated patch to current head (2.84 KB, patch)
2011-10-14 03:29 PDT, Grzegorz Czajkowski 		no flags Details | Formatted Diff | Diff
rebased patch (2.29 KB, patch)
2011-11-15 01:18 PST, Grzegorz Czajkowski 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Grzegorz Czajkowski 2011-10-13 23:08:26 PDT 
Replaces EINA_SAFETY_ON_FALSE_RETURN_VAL by EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks in compliance with WebKit-EFL functions.
Comment 1 Grzegorz Czajkowski 2011-10-13 23:09:19 PDT 
Created attachment 110965 [details]
proposed patch
Comment 2 Grzegorz Czajkowski 2011-10-14 03:20:33 PDT 
Created attachment 110988 [details]
updated patch to current head
Comment 3 Grzegorz Czajkowski 2011-10-14 03:29:15 PDT 
Created attachment 110991 [details]
updated patch to current head
Comment 4 Raphael Kubo da Costa (:rakuco) 2011-10-14 04:44:05 PDT 
Comment on attachment 110991 [details]
updated patch to current head

Informal r+.
Comment 5 Gyuyoung Kim 2011-10-14 04:49:56 PDT 
Comment on attachment 110991 [details]
updated patch to current head

LGTM.
Comment 6 Grzegorz Czajkowski 2011-11-15 01:18:31 PST 
Created attachment 115119 [details]
rebased patch
Comment 7 Filip Pizlo 2011-11-15 01:56:33 PST 
Comment on attachment 115119 [details]
rebased patch

r=me
Comment 8 WebKit Review Bot 2011-11-15 03:03:54 PST 
Comment on attachment 115119 [details]
rebased patch

Clearing flags on attachment: 115119

Committed r100261: <http://trac.webkit.org/changeset/100261>
Comment 9 WebKit Review Bot 2011-11-15 03:03:59 PST 
All reviewed patches have been landed.  Closing bug.