RESOLVED FIXED70091
[EFL] Use EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks instead of EINA_SAFETY_ON_FALSE_RETURN_VAL 
https://bugs.webkit.org/show_bug.cgi?id=70091
Summary [EFL] Use EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks instead of EINA_SAFE...
Grzegorz Czajkowski
Reported 2011-10-13 23:08:26 PDT
Replaces EINA_SAFETY_ON_FALSE_RETURN_VAL by EINA_SAFETY_ON_NULL_RETURN_VAL for NULL checks in compliance with WebKit-EFL functions.
Attachments
proposed patch (2.83 KB, patch)
2011-10-13 23:09 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
updated patch to current head (2.99 KB, patch)
2011-10-14 03:20 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
updated patch to current head (2.84 KB, patch)
2011-10-14 03:29 PDT, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
rebased patch (2.29 KB, patch)
2011-11-15 01:18 PST, Grzegorz Czajkowski 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Grzegorz Czajkowski
Comment 1 2011-10-13 23:09:19 PDT
Created attachment 110965 [details] proposed patch
Grzegorz Czajkowski
Comment 2 2011-10-14 03:20:33 PDT
Created attachment 110988 [details] updated patch to current head
Grzegorz Czajkowski
Comment 3 2011-10-14 03:29:15 PDT
Created attachment 110991 [details] updated patch to current head
Raphael Kubo da Costa (:rakuco)
Comment 4 2011-10-14 04:44:05 PDT
Comment on attachment 110991 [details] updated patch to current head Informal r+.
Gyuyoung Kim
Comment 5 2011-10-14 04:49:56 PDT
Comment on attachment 110991 [details] updated patch to current head LGTM.
Grzegorz Czajkowski
Comment 6 2011-11-15 01:18:31 PST
Created attachment 115119 [details] rebased patch
Filip Pizlo
Comment 7 2011-11-15 01:56:33 PST
Comment on attachment 115119 [details] rebased patch r=me
WebKit Review Bot
Comment 8 2011-11-15 03:03:54 PST
Comment on attachment 115119 [details] rebased patch Clearing flags on attachment: 115119 Committed r100261: <http://trac.webkit.org/changeset/100261>
WebKit Review Bot
Comment 9 2011-11-15 03:03:59 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.