Bug 70076 - [chromium] Make it possible for plugins to get current fullscreen element.
Summary: [chromium] Make it possible for plugins to get current fullscreen element.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-13 17:03 PDT by polina
Modified: 2011-10-14 01:04 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.86 KB, patch)
2011-10-13 17:16 PDT, polina 		no flags Details | Formatted Diff | Diff
Patch (3.16 KB, patch)
2011-10-13 23:33 PDT, polina 		no flags Details | Formatted Diff | Diff
Patch (3.12 KB, patch)
2011-10-14 00:12 PDT, polina 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description polina 2011-10-13 17:03:44 PDT 
WebCore::Document already has webkitCurrentFullScreenElement(). Add a wrapper for it in WebKit::WebDocument.
Comment 1 polina 2011-10-13 17:16:19 PDT 
Created attachment 110939 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-13 17:18:34 PDT 
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Comment 3 polina 2011-10-13 18:50:52 PDT 
Comment on attachment 110939 [details]
Patch

Chromium side patch:
http://codereview.chromium.org/8273029/
Comment 4 Darin Fisher (:fishd, Google) 2011-10-13 21:51:13 PDT 
Comment on attachment 110939 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110939&action=review

thanks for fixing those style issues!

> Source/WebKit/chromium/public/WebDocument.h:102
> +    WEBKIT_EXPORT WebElement fullScreenElement();

nit: like the other getters, this should be a 'const' method.

> Source/WebKit/chromium/src/WebDocument.cpp:197
> +      return WebElement(fullScreenElement);

nit: should be indented by 4 spaces
Comment 5 polina 2011-10-13 23:33:10 PDT 
Created attachment 110969 [details]
Patch
Comment 6 Darin Fisher (:fishd, Google) 2011-10-13 23:52:59 PDT 
Comment on attachment 110969 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110969&action=review

> Source/WebKit/chromium/src/WebDocument.cpp:195
> +    Element* fullScreenElement = constUnwrap<Document>()->webkitCurrentFullScreenElement();

I believe the following should work too:

  return WebElement(constUnwrap<Document>()->webkitCurrentFullScreenElement());

It can handle being initialized with a NULL Element.
Comment 7 polina 2011-10-14 00:12:29 PDT 
Created attachment 110972 [details]
Patch
Comment 8 WebKit Review Bot 2011-10-14 01:03:59 PDT 
Comment on attachment 110972 [details]
Patch

Clearing flags on attachment: 110972

Committed r97447: <http://trac.webkit.org/changeset/97447>
Comment 9 WebKit Review Bot 2011-10-14 01:04:04 PDT 
All reviewed patches have been landed.  Closing bug.