RESOLVED FIXED 70068
Reflective Arguments retrieval should be hardened for the possibility of inlining 
https://bugs.webkit.org/show_bug.cgi?id=70068
Summary Reflective Arguments retrieval should be hardened for the possibility of inli...
Filip Pizlo
Reported 2011-10-13 15:50:54 PDT
Currently, to retrieve the Arguments of a function on the call stack, we assume that the call stack contains an explicit entry for that function. This won't be the case if the function is inlined. Call stack walking for the purpose of JS-visible reflection should be able to rematerialize call frames of inlined functions, and arguments retrieval should be hardened for this possibility.
Attachments
the patch (30.79 KB, patch)
2011-10-13 15:59 PDT, Filip Pizlo 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2011-10-13 15:59:17 PDT
Created attachment 110920 [details] the patch
WebKit Review Bot
Comment 2 2011-10-13 16:01:39 PDT
Attachment 110920 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/bytecode/CodeOrigin.h:26: #ifndef header guard has wrong style, please use: CodeOrigin_h [build/header_guard] [5] Total errors found: 1 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Oliver Hunt
Comment 3 2011-10-13 16:06:21 PDT
Comment on attachment 110920 [details] the patch Fix the minor style error
Filip Pizlo
Comment 4 2011-10-14 15:00:49 PDT
Landed in r97512.
Note You need to log in before you can comment on or make changes to this bug.