Bug 70068 - Reflective Arguments retrieval should be hardened for the possibility of inlining
Summary: Reflective Arguments retrieval should be hardened for the possibility of inli...
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 69996
  Show dependency treegraph
Reported: 2011-10-13 15:50 PDT by Filip Pizlo
Modified: 2011-10-14 15:00 PDT (History)
1 user (show)

See Also:

the patch (30.79 KB, patch)
2011-10-13 15:59 PDT, Filip Pizlo
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-10-13 15:50:54 PDT
Currently, to retrieve the Arguments of a function on the call stack, we assume that the call stack contains an explicit entry for that function.  This won't be the case if the function is inlined.  Call stack walking for the purpose of JS-visible reflection should be able to rematerialize call frames of inlined functions, and arguments retrieval should be hardened for this possibility.
Comment 1 Filip Pizlo 2011-10-13 15:59:17 PDT
Created attachment 110920 [details]
the patch
Comment 2 WebKit Review Bot 2011-10-13 16:01:39 PDT
Attachment 110920 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/bytecode/CodeOrigin.h:26:  #ifndef header guard has wrong style, please use: CodeOrigin_h  [build/header_guard] [5]
Total errors found: 1 in 17 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Oliver Hunt 2011-10-13 16:06:21 PDT
Comment on attachment 110920 [details]
the patch

Fix the minor style error
Comment 4 Filip Pizlo 2011-10-14 15:00:49 PDT
Landed in r97512.