Bug 70053 - [Qt][WK2] WebErrorsQt.cpp duplicates code from WKError.h and WebError.h
Summary: [Qt][WK2] WebErrorsQt.cpp duplicates code from WKError.h and WebError.h
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jesus Sanchez-Palencia
Keywords: Qt, QtTriaged
Depends on:
Reported: 2011-10-13 14:04 PDT by Jesus Sanchez-Palencia
Modified: 2011-10-13 14:20 PDT (History)
1 user (show)

See Also:

Patch (4.71 KB, patch)
2011-10-13 14:08 PDT, Jesus Sanchez-Palencia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jesus Sanchez-Palencia 2011-10-13 14:04:05 PDT
We should use the shared error codes enum from Source/WebKit2/Shared/API/c/WKError.h instead of our custom "WebKitError*" codes to keep it aligned with all WebKit2 ports. We should also use WebError::webkitErrorDomain() instead of using a "WebKit" as the error domain for these errors.
Comment 1 Kenneth Rohde Christiansen 2011-10-13 14:06:15 PDT
Sounds good if this is possible
Comment 2 Jesus Sanchez-Palencia 2011-10-13 14:08:32 PDT
Created attachment 110904 [details]
Comment 3 Jesus Sanchez-Palencia 2011-10-13 14:20:04 PDT
Comment on attachment 110904 [details]

Clearing flags on attachment: 110904

Committed r97399: <http://trac.webkit.org/changeset/97399>
Comment 4 Jesus Sanchez-Palencia 2011-10-13 14:20:11 PDT
All reviewed patches have been landed.  Closing bug.