Bug 70037 - [Qt] enable qmltests for qt5
Summary: [Qt] enable qmltests for qt5
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-13 10:40 PDT by Gopal Raghavan
Modified: 2011-10-14 07:56 PDT (History)
3 users (show)

See Also:


Attachments
enable qmltests (1.15 KB, patch)
2011-10-13 10:44 PDT, Gopal Raghavan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gopal Raghavan 2011-10-13 10:40:01 PDT
qmltests seem to be disabled for some reason.
Comment 1 Gopal Raghavan 2011-10-13 10:44:49 PDT
Created attachment 110875 [details]
enable qmltests

qmltests runs again for qt5
Comment 2 Chang Shu 2011-10-14 06:34:51 PDT
Comment on attachment 110875 [details]
enable qmltests

View in context: https://bugs.webkit.org/attachment.cgi?id=110875&action=review

The code change is ok but better to communicate with Ossy when to land this patch. After landing, please also keep an eye on the bot: http://build.webkit.sed.hu/buildslaves/szeged-linux-22

> Source/WebKit2/ChangeLog:8
> +        Qml tests seem to be disabled for some reason. This patch enables the tests by including qmltests to SUBDIRS.

Please wrap the description in the future.
Comment 3 Chang Shu 2011-10-14 06:45:18 PDT
Ossy, I just r+ed this patch.
Comment 4 WebKit Review Bot 2011-10-14 07:56:55 PDT
Comment on attachment 110875 [details]
enable qmltests

Clearing flags on attachment: 110875

Committed r97466: <http://trac.webkit.org/changeset/97466>
Comment 5 WebKit Review Bot 2011-10-14 07:56:59 PDT
All reviewed patches have been landed.  Closing bug.