Bug 70035 - feColorMatrix doesn't use the correct default "matrix" type when no type attribute is specified
Summary: feColorMatrix doesn't use the correct default "matrix" type when no type attr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-10-13 09:56 PDT by Tim Horton
Modified: 2011-10-24 15:55 PDT (History)
4 users (show)

See Also:

Attachments
repro: the images should be identical (858 bytes, image/svg+xml)
2011-10-13 10:00 PDT, Tim Horton 		no flags Details
super simple patch (6.78 KB, patch)
2011-10-21 15:07 PDT, Tim Horton 		zimmermann: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2011-10-13 09:56:37 PDT 
From the SVG1.1SE spec: "If attribute ‘type’ is not specified, then the effect is as if a value of matrix were specified."

This isn't the case in WebKit at the moment. Repro attached.
Comment 1 Radar WebKit Bug Importer 2011-10-13 09:57:20 PDT 
<rdar://problem/10280177>
Comment 2 Tim Horton 2011-10-13 10:00:01 PDT 
Created attachment 110862 [details]
repro: the images should be identical
Comment 3 Tim Horton 2011-10-13 10:03:40 PDT 
*should be identical and both red, I should have specified*
Comment 4 Tim Horton 2011-10-21 15:07:11 PDT 
Created attachment 112029 [details]
super simple patch
Comment 5 WebKit Review Bot 2011-10-21 15:39:22 PDT 
Comment on attachment 112029 [details]
super simple patch

Attachment 112029 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10197081

New failing tests:
svg/filters/feColorMatrix-default-type.svg
Comment 6 Nikolas Zimmermann 2011-10-21 23:45:52 PDT 
Comment on attachment 112029 [details]
super simple patch

r=me. Do you really want to put the png in svg/filters, instead of platform/mac/svg/filters, same for the .txt file. Please consider moving them before landing.
Comment 7 Tim Horton 2011-10-24 15:55:54 PDT 
(In reply to comment #6)
> (From update of attachment 112029 [details])
> r=me. Do you really want to put the png in svg/filters, instead of platform/mac/svg/filters, same for the .txt file. Please consider moving them before landing.

Fixed, landed in 98293.