Bug 70033 - Web Inspector: move JS specific popover handling to JavaScriptSourceFrame.
Summary: Web Inspector: move JS specific popover handling to JavaScriptSourceFrame.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Podivilov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-13 09:41 PDT by Pavel Podivilov
Modified: 2011-10-19 02:47 PDT (History)
10 users (show)

See Also:


Attachments
Patch (16.51 KB, patch)
2011-10-13 09:43 PDT, Pavel Podivilov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Podivilov 2011-10-13 09:41:57 PDT
Web Inspector: move JS specific popover handling to JavaScriptSourceFrame.
Comment 1 Pavel Podivilov 2011-10-13 09:43:36 PDT
Created attachment 110860 [details]
Patch
Comment 2 Pavel Feldman 2011-10-16 10:37:21 PDT
Comment on attachment 110860 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110860&action=review

> Source/WebCore/inspector/front-end/SourceFrame.js:836
> +    shouldShowPopover: function(element) { },

It is not clear what part of extensibility is achieved by means of the delegate versus the abstract methods. You should choose one way of extensibility and stick to it. r- for that.
Comment 3 Pavel Podivilov 2011-10-17 03:48:45 PDT
Extensibility should be achieved  by means of the abstract methods.
Delegate only serves for eliminating circular dependency between ScriptsPanel and JSSF. Delegate will have just two methods after refactoring: setScriptSourceIsBeingEdited and suggestedFileName. We may even get rid of it completely.
Comment 4 Pavel Feldman 2011-10-17 06:34:57 PDT
Comment on attachment 110860 [details]
Patch

Ok, I'd like to see delegates gone in the end of this refactoring then.
Comment 5 Pavel Podivilov 2011-10-19 02:47:48 PDT
Committed r97843: <http://trac.webkit.org/changeset/97843>