Web Inspector: move JS specific popover handling to JavaScriptSourceFrame.
Created attachment 110860 [details] Patch
Comment on attachment 110860 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110860&action=review > Source/WebCore/inspector/front-end/SourceFrame.js:836 > + shouldShowPopover: function(element) { }, It is not clear what part of extensibility is achieved by means of the delegate versus the abstract methods. You should choose one way of extensibility and stick to it. r- for that.
Extensibility should be achieved by means of the abstract methods. Delegate only serves for eliminating circular dependency between ScriptsPanel and JSSF. Delegate will have just two methods after refactoring: setScriptSourceIsBeingEdited and suggestedFileName. We may even get rid of it completely.
Comment on attachment 110860 [details] Patch Ok, I'd like to see delegates gone in the end of this refactoring then.
Committed r97843: <http://trac.webkit.org/changeset/97843>