Bug 70018 - Web Inspector: Editing CSS selector doesn't fire onResourceContentCommitted
Summary: Web Inspector: Editing CSS selector doesn't fire onResourceContentCommitted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-13 04:43 PDT by Nikita Vasilyev
Modified: 2011-10-17 04:45 PDT (History)
11 users (show)

See Also:

Attachments
[PATCH] Suggested fix (3.19 KB, patch)
2011-10-13 06:30 PDT, Alexander Pavlov (apavlov) 		no flags Details | Formatted Diff | Diff
[PATCH] ChangeLog entries added (4.55 KB, patch)
2011-10-14 02:12 PDT, Alexander Pavlov (apavlov) 		pfeldman: review-
Details | Formatted Diff | Diff
[PATCH] Compiler annotations added (8.79 KB, patch)
2011-10-17 03:34 PDT, Alexander Pavlov (apavlov) 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2011-10-13 04:43:41 PDT 
Also, a stylesheet in Resources panel doesn't change as well.
Comment 1 Alexander Pavlov (apavlov) 2011-10-13 06:30:00 PDT 
Created attachment 110836 [details]
[PATCH] Suggested fix
Comment 2 Alexander Pavlov (apavlov) 2011-10-13 09:39:23 PDT 
Comment on attachment 110836 [details]
[PATCH] Suggested fix

Patch sent too soon, without ChangeLog entries
Comment 3 Alexander Pavlov (apavlov) 2011-10-14 02:12:09 PDT 
Created attachment 110983 [details]
[PATCH] ChangeLog entries added
Comment 4 Pavel Feldman 2011-10-16 10:12:02 PDT 
Comment on attachment 110983 [details]
[PATCH] ChangeLog entries added

View in context: https://bugs.webkit.org/attachment.cgi?id=110983&action=review

> Source/WebCore/inspector/front-end/CSSStyleModel.js:139
> +        function callback(nodeId, successCallback, failureCallback, newSelector, error, rulePayload)

Could you annotate this for closure compiler so that we don't hit it again?
Comment 5 Alexander Pavlov (apavlov) 2011-10-17 03:34:16 PDT 
Created attachment 111238 [details]
[PATCH] Compiler annotations added

Unfortunately, the annotations don't help to detect this particular error (the compiler does not handle the "bind" method semantics.)
Comment 6 Yury Semikhatsky 2011-10-17 04:34:55 PDT 
Comment on attachment 111238 [details]
[PATCH] Compiler annotations added

View in context: https://bugs.webkit.org/attachment.cgi?id=111238&action=review

> LayoutTests/inspector/styles/commit-selector.html:17
> +    var section;

Move it into step1?
Comment 7 Alexander Pavlov (apavlov) 2011-10-17 04:45:27 PDT 
Committed r97606: <http://trac.webkit.org/changeset/97606>