RESOLVED FIXED 70018
Web Inspector: Editing CSS selector doesn't fire onResourceContentCommitted 
https://bugs.webkit.org/show_bug.cgi?id=70018
Summary Web Inspector: Editing CSS selector doesn't fire onResourceContentCommitted
Nikita Vasilyev
Reported 2011-10-13 04:43:41 PDT
Also, a stylesheet in Resources panel doesn't change as well.
Attachments
[PATCH] Suggested fix (3.19 KB, patch)
2011-10-13 06:30 PDT, Alexander Pavlov (apavlov) 		no flags
DetailsFormatted DiffDiff
[PATCH] ChangeLog entries added (4.55 KB, patch)
2011-10-14 02:12 PDT, Alexander Pavlov (apavlov) 		pfeldman: review-
DetailsFormatted DiffDiff
[PATCH] Compiler annotations added (8.79 KB, patch)
2011-10-17 03:34 PDT, Alexander Pavlov (apavlov) 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Alexander Pavlov (apavlov)
Comment 1 2011-10-13 06:30:00 PDT
Created attachment 110836 [details] [PATCH] Suggested fix
Alexander Pavlov (apavlov)
Comment 2 2011-10-13 09:39:23 PDT
Comment on attachment 110836 [details] [PATCH] Suggested fix Patch sent too soon, without ChangeLog entries
Alexander Pavlov (apavlov)
Comment 3 2011-10-14 02:12:09 PDT
Created attachment 110983 [details] [PATCH] ChangeLog entries added
Pavel Feldman
Comment 4 2011-10-16 10:12:02 PDT
Comment on attachment 110983 [details] [PATCH] ChangeLog entries added View in context: https://bugs.webkit.org/attachment.cgi?id=110983&action=review > Source/WebCore/inspector/front-end/CSSStyleModel.js:139 > + function callback(nodeId, successCallback, failureCallback, newSelector, error, rulePayload) Could you annotate this for closure compiler so that we don't hit it again?
Alexander Pavlov (apavlov)
Comment 5 2011-10-17 03:34:16 PDT
Created attachment 111238 [details] [PATCH] Compiler annotations added Unfortunately, the annotations don't help to detect this particular error (the compiler does not handle the "bind" method semantics.)
Yury Semikhatsky
Comment 6 2011-10-17 04:34:55 PDT
Comment on attachment 111238 [details] [PATCH] Compiler annotations added View in context: https://bugs.webkit.org/attachment.cgi?id=111238&action=review > LayoutTests/inspector/styles/commit-selector.html:17 > + var section; Move it into step1?
Alexander Pavlov (apavlov)
Comment 7 2011-10-17 04:45:27 PDT
Committed r97606: <http://trac.webkit.org/changeset/97606>
Note You need to log in before you can comment on or make changes to this bug.