WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
70011
script-src * should allow all URLs
https://bugs.webkit.org/show_bug.cgi?id=70011
Summary
script-src * should allow all URLs
Adam Barth
Reported
2011-10-13 02:40:47 PDT
script-src * should allow all URLs
Attachments
Patch
(4.86 KB, patch)
2011-10-13 02:50 PDT
,
Adam Barth
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2011-10-13 02:50:44 PDT
Created
attachment 110816
[details]
Patch
Eric Seidel (no email)
Comment 2
2011-10-13 02:53:17 PDT
Comment on
attachment 110816
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=110816&action=review
OK.
> Source/WebCore/page/ContentSecurityPolicy.cpp:273 > + if (end - begin == 1 && *begin == '*') {
It seems like you should have a local length = end - begin? Or do you move begin?
Adam Barth
Comment 3
2011-10-13 02:54:24 PDT
Comment on
attachment 110816
[details]
Patch Yeah, begin and end get moved around a lot in this function. I'd prefer not to have a length variable because I'd worry it would get out of sync.
WebKit Review Bot
Comment 4
2011-10-13 03:15:48 PDT
Comment on
attachment 110816
[details]
Patch Clearing flags on attachment: 110816 Committed
r97360
: <
http://trac.webkit.org/changeset/97360
>
WebKit Review Bot
Comment 5
2011-10-13 03:15:52 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug