Bug 70010 - [GTK] Add WebKitTestServer class to WebKit2 GTK+ unit tests library
Summary: [GTK] Add WebKitTestServer class to WebKit2 GTK+ unit tests library
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 69343
  Show dependency tree / graph
 
Reported: 2011-10-13 02:21 PDT by Carlos Garcia Campos
Modified: 2011-10-13 08:27 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.52 KB, patch)
2011-10-13 02:37 PDT, Carlos Garcia Campos 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-10-13 02:21:39 PDT 
It makes easier to write tests that use a soup server.
Comment 1 Carlos Garcia Campos 2011-10-13 02:37:50 PDT 
Created attachment 110815 [details]
Patch
Comment 2 WebKit Review Bot 2011-10-13 02:43:41 PDT 
Attachment 110815 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/UIProcess/API/gtk/tests/WebKitTestServer.cpp:26:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Martin Robinson 2011-10-13 08:15:02 PDT 
Comment on attachment 110815 [details]
Patch

Great. I was thinking of doing this too.
Comment 4 Carlos Garcia Campos 2011-10-13 08:27:49 PDT 
Committed r97366: <http://trac.webkit.org/changeset/97366>