Bug 69991 - Add regression test: canvas.toDataURL("image/jpeg") should not crash
Summary: Add regression test: canvas.toDataURL("image/jpeg") should not crash
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: noel gordon
URL: http://persistent.info/chromium/test-...
Keywords:
Depends on: 69681
Blocks:
  Show dependency tree / graph
 
Reported: 2011-10-12 19:48 PDT by noel gordon
Modified: 2011-10-13 12:24 PDT (History)
5 users (show)

See Also:

Attachments
Patch (1.89 KB, patch)
2011-10-12 19:51 PDT, noel gordon 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description noel gordon 2011-10-12 19:48:14 PDT 
Reproduced bug 69681 with the above URL, construct a regression test from it.
Comment 1 noel gordon 2011-10-12 19:51:36 PDT 
Created attachment 110797 [details]
Patch
Comment 2 noel gordon 2011-10-12 20:27:15 PDT 
mac-ews and cr-mac-ews are a mess at the moment, ... so compiled mac-chrome without http://trac.webkit.org/changeset/97132 and
-DWTF_USE_SKIA_ON_MAC_CHROMIUM=0.  The patch test case crashes.  Added http://trac.webkit.org/changeset/97132 and patch test
case passes.
Comment 3 Kenneth Russell 2011-10-12 20:32:11 PDT 
Comment on attachment 110797 [details]
Patch

Very nice. r=me
Comment 4 John Bauman 2011-10-12 20:33:11 PDT 
Thanks for doing this. Looks good.
Comment 5 noel gordon 2011-10-12 21:54:57 PDT 
No worries.  build-webkit --debug at r97243 and the test passes for me.  I was unable to reproduce with a webkit nightly (r96471)  though.
Comment 6 WebKit Review Bot 2011-10-13 12:24:04 PDT 
Comment on attachment 110797 [details]
Patch

Clearing flags on attachment: 110797

Committed r97382: <http://trac.webkit.org/changeset/97382>
Comment 7 WebKit Review Bot 2011-10-13 12:24:09 PDT 
All reviewed patches have been landed.  Closing bug.