Bug 69990 - [nrwt] Add new category for MISSING
Summary: [nrwt] Add new category for MISSING
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on: 67268
Blocks:
  Show dependency treegraph
 
Reported: 2011-10-12 19:18 PDT by Ryosuke Niwa
Modified: 2011-10-18 02:11 PDT (History)
5 users (show)

See Also:


Attachments
fixes the bug (7.78 KB, patch)
2011-10-17 16:16 PDT, Ryosuke Niwa
dpranke: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-10-12 19:18:49 PDT
We shouldn't treat MISSING as flaky. Also we should cleanup summarize_results. It has gotten really big, has many hacks, and is inconsistent with the rest of the codebase.
Comment 1 Ryosuke Niwa 2011-10-17 16:16:19 PDT
Created attachment 111342 [details]
fixes the bug
Comment 2 Dirk Pranke 2011-10-17 16:22:10 PDT
Comment on attachment 111342 [details]
fixes the bug

View in context: https://bugs.webkit.org/attachment.cgi?id=111342&action=review

> Tools/Scripts/webkitpy/layout_tests/port/base.py:725
> +        # Don't turn bots red for flaky failures, unexpected passes, and missing results.

Nit: Can you add a docstring to this with a more informative explanation of what this routine is doing? (you can probably re-use the comment).
Comment 3 Ryosuke Niwa 2011-10-17 16:41:39 PDT
Committed r97672: <http://trac.webkit.org/changeset/97672>
Comment 4 Ryosuke Niwa 2011-10-18 02:11:12 PDT
Apparently the test was failing :(  Fixed it in http://trac.webkit.org/changeset/97730.