Bug 69976 – Kill old run-webkit-tests processes in kill-process on Mac

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Ryosuke Niwa]

We should kill all python instances executing run-webkit-tests.

[Ryosuke Niwa]

Created attachment 110771 [details]
adds a new system call to kill-old-processes

[Eric Seidel (no email)]

Comment on attachment 110771 [details]
adds a new system call to kill-old-processes

Um.  You want to call this once for each task?  Makes no sense.

[Tony Chang]

What about the buildbot process?

[Ryosuke Niwa]

(In reply to comment #2)
> (From update of attachment 110771 [details])
> Um.  You want to call this once for each task?  Makes no sense.

I don't quite get what you mean. We need to kill all python instances running run-webkit-tests (in particular child processes created by manager.py). How else can we accomplish this?

[Ryosuke Niwa]

(In reply to comment #3)
> What about the buildbot process?

The bug 63651 will enable kill-old-processes on Mac so this will be a buildbot step.

[Tony Chang]

(In reply to comment #5)
> (In reply to comment #3)
> > What about the buildbot process?
> 
> The bug 63651 will enable kill-old-processes on Mac so this will be a buildbot step.

I mean, buildbot is a python process.  You probably don't want to kill it.

[Ryosuke Niwa]

(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #3)
> > > What about the buildbot process?
> > 
> > The bug 63651 will enable kill-old-processes on Mac so this will be a buildbot step.
> 
> I mean, buildbot is a python process.  You probably don't want to kill it.

Right, that's why I'm explicitly looking for python process with run-webkit-test string:
grep -P '.+/Python .+(run_webkit_tests|run-webkit-tests)'

[Tony Chang]

Comment on attachment 110771 [details]
adds a new system call to kill-old-processes

View in context: https://bugs.webkit.org/attachment.cgi?id=110771&action=review

> Tools/BuildSlaveSupport/kill-old-processes:80
> +            # Kill all instances of pyhton executing run-webkit-tests

typo: pyhton

[Eric Seidel (no email)]

Comment on attachment 110771 [details]
adds a new system call to kill-old-processes

View in context: https://bugs.webkit.org/attachment.cgi?id=110771&action=review

> Tools/BuildSlaveSupport/kill-old-processes:81
> +            os.system("aux | grep -P '.+/Python .+(run_webkit_tests|run-webkit-tests)' | grep -v grep | awk '{print $2}' | xargs kill")

You're runing this in a loop.  Once for every "task" in the array.  WHy?

[Ryosuke Niwa]

Comment on attachment 110771 [details]
adds a new system call to kill-old-processes

View in context: https://bugs.webkit.org/attachment.cgi?id=110771&action=review

>> Tools/BuildSlaveSupport/kill-old-processes:81
>> +            os.system("aux | grep -P '.+/Python .+(run_webkit_tests|run-webkit-tests)' | grep -v grep | awk '{print $2}' | xargs kill")
> 
> You're runing this in a loop.  Once for every "task" in the array.  WHy?

Oh oops, that's definitely a typo!  Will fix.

This is why I hate python :(

[Ryosuke Niwa]

Created attachment 110776 [details]
Fixed indentation and typo

[Dirk Pranke]

Comment on attachment 110776 [details]
Fixed indentation and typo

View in context: https://bugs.webkit.org/attachment.cgi?id=110776&action=review

> Tools/BuildSlaveSupport/kill-old-processes:81
> +        os.system("aux | grep -P '.+/Python .+(run_webkit_tests|run-webkit-tests)' | grep -v grep | awk '{print $2}' | xargs kill")

presumably this should be "ps aux" at the beginning?

[Dirk Pranke]

(In reply to comment #12)
> (From update of attachment 110776 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=110776&action=review
> 
> > Tools/BuildSlaveSupport/kill-old-processes:81
> > +        os.system("aux | grep -P '.+/Python .+(run_webkit_tests|run-webkit-tests)' | grep -v grep | awk '{print $2}' | xargs kill")
> 
> presumably this should be "ps aux" at the beginning?

Also, if you add this, can you remove 'httpd' from tasksToKill? NRWT should restart httpd itself correctly on the next run, if it started the last one.

[Ryosuke Niwa]

Created attachment 110780 [details]
new patch

[Ryosuke Niwa]

Created attachment 110781 [details]
new patch 2

Oops, wrong file.

[WebKit Review Bot]

Comment on attachment 110781 [details]
new patch 2

Clearing flags on attachment: 110781

Committed r97330: <http://trac.webkit.org/changeset/97330>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.