Bug 69962 – [Chromium] Make it possible to create and dispatch a message event through chromium API

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dave Michael]

Make it possible to create and dispatch a message event through chromium API

[Dave Michael]

Created attachment 110742 [details]
Patch

[WebKit Review Bot]

Please wait for approval from [e-mail] before submitting because this patch contains changes to the Chromium public API.

[Dave Michael]

This is to support 'PostMessage' for the Pepper plugin API. We currently use a simple scripting approach, but it's very limited. This is a first step to allow me to create an Event in the Chromium renderer and dispatch it to JavaScript.

Here's the corresponding Chromium bug:
http://code.google.com/p/chromium/issues/detail?id=82604

[Darin Fisher (:fishd, Google)]

Comment on attachment 110742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110742&action=review

API changes LGTM modulo the nit.

> Source/WebKit/chromium/public/WebDOMMessageEvent.h:48
> +    WEBKIT_EXPORT void initMessageEvent(const WebString& type, bool canBubble, bool cancelable, const WebSerializedScriptValue& message_data, const WebString& origin, const WebFrame& sourceFrame, const WebString& lastEventId, const WebMessagePortChannelArray& webChannels);

nit: message_data -> messageData

> Source/WebKit/chromium/src/PlatformMessagePortChannel.cpp:239
> +    return m_localPort && m_localPort->hasPendingActivity();

I'm not super familiar with this code.  It would be good to get someone
like [e-mail] to look over this patch too.

[Darin Fisher (:fishd, Google)]

[e-mail]:  Dave, it'd be great to get your eyes on this one too.

[Dave Michael]

Created attachment 110858 [details]
Patch

[David Levin]

Comment on attachment 110858 [details]
Patch

Please fix the include sorting and then we can get this landed.

[Dave Michael]

Created attachment 112246 [details]
Patch

[David Levin]

Comment on attachment 112246 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=112246&action=review

> Source/WebKit/chromium/ChangeLog:5
> +        Removed messageChannels parameter, since it's hard to get right and I don't need it. Changed message_data->messageData. Reordered includes.

In general you don't need interpatch info here.

[WebKit Review Bot]

Comment on attachment 112246 [details]
Patch

Rejecting attachment 112246 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
omium/src/PlatformMessagePortChannel.cpp
patching file Source/WebKit/chromium/src/WebDOMEvent.cpp
Hunk #1 succeeded at 69 (offset 3 lines).
patching file Source/WebKit/chromium/src/WebDOMMessageEvent.cpp
patching file Source/WebKit/chromium/src/WebDocument.cpp
Hunk #2 succeeded at 199 with fuzz 1 (offset 9 lines).
patching file Source/WebKit/chromium/src/WebNode.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'David Levin', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/10210007

[David Levin]

Your patch didn't apply. Please update your tree, resolve any conflicts and upload a new patch.

[Dave Michael]

Created attachment 112342 [details]
Patch

[WebKit Review Bot]

Comment on attachment 112342 [details]
Patch

Rejecting attachment 112342 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Review Bot]

Comment on attachment 112342 [details]
Patch

Clearing flags on attachment: 112342

Committed r98381: <http://trac.webkit.org/changeset/98381>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.