Created attachment 110736 [details] test case Summary: border-right doesn't correctly take vertical writing mode into account See test case.
This actually has nothing to do with borders.
Created attachment 110788 [details] Patch
Here's a first attempt. I'm a bit dubious this is the right fix given the call to computeLogicalHeight. It fixes the bug though.
Comment on attachment 110788 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110788&action=review > Source/WebCore/rendering/RenderBlock.cpp:5247 > + toRenderBox(child)->computeLogicalHeight(); Yeah this is not quite right. It will use a height from a previous layout for the auto case, and that's pretty weird. I think you need to set the intrinsic height to just be borders + padding, then do computeLogicalHeight, and then use that result. However in addition, this computation needs to not have side effects, i.e., you need to set the height back to what it was when you're finished. Note that I'm approaching the point with region refactoring that I'm probably going to give you a way to compute the height/width without updating the box's member variables, since this hack of "compute it but then set it back" is starting to become really widespread. So anyway to sum up: (1) Cache the old height (2) Set the new height to be borders and padding in the logical height direction. (3) Compute the logical height (4) Cache that as your preferred logical width. (5) Set it back to the old height.
Created attachment 111101 [details] Patch
Comment on attachment 111101 [details] Patch r=me
Committed r97653: <http://trac.webkit.org/changeset/97653>
Reverted r97653 for reason: Caused a number of Chromium failures. Committed r97661: <http://trac.webkit.org/changeset/97661>
Committed r97693: <http://trac.webkit.org/changeset/97693>