RESOLVED FIXED 69951
Deprecate event.layerX and event.layerY in WebKit 
https://bugs.webkit.org/show_bug.cgi?id=69951
Summary Deprecate event.layerX and event.layerY in WebKit
Julien Chaffraix
Reported 2011-10-12 12:35:10 PDT
Following Sam's comment on bug 21868, the best way to remove event.layerX and event.layerY is to first deprecate them from the ObjC API - the other API don't mind a direct removal - in order to remove them. As we need to keep the code in WebKit until it is removed from the public API, let's mark it as deprecated so that web-authors are prepared for the removal too.
Attachments
Proposed change: send a warning to the console and deprecate the properties in the ObjC API. (13.41 KB, patch)
2011-10-12 13:00 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Proposed change 2: missed one test to update. (14.03 KB, patch)
2011-10-12 18:25 PDT, Julien Chaffraix 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Julien Chaffraix
Comment 1 2011-10-12 13:00:54 PDT
Created attachment 110725 [details] Proposed change: send a warning to the console and deprecate the properties in the ObjC API.
WebKit Review Bot
Comment 2 2011-10-12 14:02:22 PDT
Comment on attachment 110725 [details] Proposed change: send a warning to the console and deprecate the properties in the ObjC API. Attachment 110725 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10041031 New failing tests: jquery/event.html
Julien Chaffraix
Comment 3 2011-10-12 18:25:50 PDT
Created attachment 110787 [details] Proposed change 2: missed one test to update.
Darin Adler
Comment 4 2011-10-13 08:46:40 PDT
Comment on attachment 110787 [details] Proposed change 2: missed one test to update. Seems OK, but doesn’t help us get the data about what sites will be affected. Is there some simple way we can find out?
Julien Chaffraix
Comment 5 2011-10-13 11:33:02 PDT
> Seems OK, but doesn’t help us get the data about what sites will be affected. > Is there some simple way we can find out? Chromium has some reporting that we could use. Unfortunately we won't get the individual websites but an aggregate of how much popular the properties are.
WebKit Review Bot
Comment 6 2011-10-13 12:06:12 PDT
Comment on attachment 110787 [details] Proposed change 2: missed one test to update. Clearing flags on attachment: 110787 Committed r97380: <http://trac.webkit.org/changeset/97380>
WebKit Review Bot
Comment 7 2011-10-13 12:06:17 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 8 2011-11-03 10:30:46 PDT
chase.com is one site that calls these a lot.
Pavel Feldman
Comment 9 2012-02-02 11:30:28 PST
I think we should make these properties non-enumerable at this point. Otherwise, we get this warning every time one iterates over event's properties (or event is expanded in the inspector).
Darin Adler
Comment 10 2012-02-02 11:49:17 PST
(In reply to comment #9) > I think we should make these properties non-enumerable at this point. That seems like a good idea.
Note You need to log in before you can comment on or make changes to this bug.