Bug 69945 - garden-o-matic should color-code test failure types.
Summary: garden-o-matic should color-code test failure types.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 69227
  Show dependency tree / graph
 
Reported: 2011-10-12 11:19 PDT by Dimitri Glazkov (Google)
Modified: 2011-10-12 11:45 PDT (History)
1 user (show)

See Also:

Attachments
Patch (15.21 KB, patch)
2011-10-12 11:20 PDT, Dimitri Glazkov (Google) 		abarth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-10-12 11:19:04 PDT 
garden-o-matic should color-code test failure types.
Comment 1 Dimitri Glazkov (Google) 2011-10-12 11:20:08 PDT 
Created attachment 110710 [details]
Patch
Comment 2 Adam Barth 2011-10-12 11:32:04 PDT 
Comment on attachment 110710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110710&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:205
> +

extra blank line

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:210
> +

ditto

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:219
> +    ol.notifications table.failures tbody tr.IMAGE\+TEXT td:first-child span {

It's lame that span here is so unsemantic.  Would it be better to use a class instead?
Comment 3 Adam Barth 2011-10-12 11:32:40 PDT 
I suspect we'll need to iterate on the UI a bit to find the right balance between information and distraction, but we've got to start somewhere.
Comment 4 Dimitri Glazkov (Google) 2011-10-12 11:34:03 PDT 
Comment on attachment 110710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110710&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:219
>> +    ol.notifications table.failures tbody tr.IMAGE\+TEXT td:first-child span {
> 
> It's lame that span here is so unsemantic.  Would it be better to use a class instead?

I still need an extra box here. Just adding a class won't help, sadly.
Comment 5 Dimitri Glazkov (Google) 2011-10-12 11:35:18 PDT 
(In reply to comment #3)
> I suspect we'll need to iterate on the UI a bit to find the right balance between information and distraction, but we've got to start somewhere.

Yep.
Comment 6 Dimitri Glazkov (Google) 2011-10-12 11:45:13 PDT 
Committed r97281: <http://trac.webkit.org/changeset/97281>