Bug 69945 – garden-o-matic should color-code test failure types.

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Dimitri Glazkov (Google)]

garden-o-matic should color-code test failure types.

[Dimitri Glazkov (Google)]

Created attachment 110710 [details]
Patch

[Adam Barth]

Comment on attachment 110710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110710&action=review

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:205
> +

extra blank line

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:210
> +

ditto

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:219
> +    ol.notifications table.failures tbody tr.IMAGE\+TEXT td:first-child span {

It's lame that span here is so unsemantic.  Would it be better to use a class instead?

[Adam Barth]

I suspect we'll need to iterate on the UI a bit to find the right balance between information and distraction, but we've got to start somewhere.

[Dimitri Glazkov (Google)]

Comment on attachment 110710 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110710&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:219
>> +    ol.notifications table.failures tbody tr.IMAGE\+TEXT td:first-child span {
> 
> It's lame that span here is so unsemantic.  Would it be better to use a class instead?

I still need an extra box here. Just adding a class won't help, sadly.

[Dimitri Glazkov (Google)]

(In reply to comment #3)
> I suspect we'll need to iterate on the UI a bit to find the right balance between information and distraction, but we've got to start somewhere.

Yep.

[Dimitri Glazkov (Google)]

Committed r97281: <http://trac.webkit.org/changeset/97281>