Bug 69929 - webkitpy tests are failing on Mac bots
Summary: webkitpy tests are failing on Mac bots
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL: http://build.webkit.org/builders/Snow...
Keywords: MakingBotsRed
Depends on:
Blocks:
 
Reported: 2011-10-12 08:05 PDT by Simon Fraser (smfr)
Modified: 2011-10-12 11:29 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.11 KB, patch)
2011-10-12 11:23 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2011-10-12 08:05:11 PDT 
webkitpy failures are contributing to bot redness. Would be good to fix.
Comment 2 David Levin 2011-10-12 09:20:42 PDT 
fyi, mostly BaselineOptimizerTest at the moment.

abarth is the man for this.
Comment 3 Adam Barth 2011-10-12 09:21:07 PDT 
Will fix.
Comment 4 Adam Barth 2011-10-12 11:10:27 PDT 
http://trac.webkit.org/changeset/97276
Comment 5 Adam Barth 2011-10-12 11:12:28 PDT 
Actually, there's still one more failure on Lion:


======================================================================
FAIL: test_all_test_configurations (webkitpy.layout_tests.port.chromium_mac_unittest.ChromiumMacPortTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Volumes/Data/slave/lion-intel-debug-tests/build/Tools/Scripts/webkitpy/layout_tests/port/port_testcase.py", line 346, in test_all_test_configurations
    self.assertTrue(port.test_configuration() in port.all_test_configurations(), "%s not in %s" % (port.test_configuration(), port.all_test_configurations()))
AssertionError: <lion, x86, release, cpu> not in [TestConfig(version='leopard', architecture='x86', build_type='debug', graphics_type='cpu'), TestConfig(version='leopard', architecture='x86', build_type='debug', graphics_type='gpu'), TestConfig(version='leopard', architecture='x86', build_type='debug', graphics_type='cpu-cg'), TestConfig(version='leopard', architecture='x86', build_type='debug', graphics_type='gpu-cg'), TestConfig(version='leopard', architecture='x86', build_type='release', graphics_type='cpu'), TestConfig(version='leopard', architecture='x86', build_type='release', graphics_type='gpu'), TestConfig(version='leopard', architecture='x86', build_type='release', graphics_type='cpu-cg'), TestConfig(version='leopard', architecture='x86', build_type='release', graphics_type='gpu-cg'), TestConfig(version='snowleopard', architecture='x86', build_type='debug', graphics_type='cpu'), TestConfig(version='snowleopard', architecture='x86', build_type='debug', graphics_type='gpu'), TestConfig(version='snowleopard', architecture='x86', build_type='debug', graphics_type='cpu-cg'), TestConfig(version='snowleopard', architecture='x86', build_type='debug', graphics_type='gpu-cg'), TestConfig(version='snowleopard', architecture='x86', build_type='release', graphics_type='cpu'), TestConfig(version='snowleopard', architecture='x86', build_type='release', graphics_type='gpu'), TestConfig(version='snowleopard', architecture='x86', build_type='release', graphics_type='cpu-cg'), TestConfig(version='snowleopard', architecture='x86', build_type='release', graphics_type='gpu-cg'), TestConfig(version='xp', architecture='x86', build_type='debug', graphics_type='cpu'), TestConfig(version='xp', architecture='x86', build_type='debug', graphics_type='gpu'), TestConfig(version='xp', architecture='x86', build_type='release', graphics_type='cpu'), TestConfig(version='xp', architecture='x86', build_type='release', graphics_type='gpu'), TestConfig(version='vista', architecture='x86', build_type='debug', graphics_type='cpu'), TestConfig(version='vista', architecture='x86', build_type='debug', graphics_type='gpu'), TestConfig(version='vista', architecture='x86', build_type='release', graphics_type='cpu'), TestConfig(version='vista', architecture='x86', build_type='release', graphics_type='gpu'), TestConfig(version='win7', architecture='x86', build_type='debug', graphics_type='cpu'), TestConfig(version='win7', architecture='x86', build_type='debug', graphics_type='gpu'), TestConfig(version='win7', architecture='x86', build_type='release', graphics_type='cpu'), TestConfig(version='win7', architecture='x86', build_type='release', graphics_type='gpu'), TestConfig(version='lucid', architecture='x86', build_type='debug', graphics_type='cpu'), TestConfig(version='lucid', architecture='x86', build_type='debug', graphics_type='gpu'), TestConfig(version='lucid', architecture='x86', build_type='release', graphics_type='cpu'), TestConfig(version='lucid', architecture='x86', build_type='release', graphics_type='gpu'), TestConfig(version='lucid', architecture='x86_64', build_type='debug', graphics_type='cpu'), TestConfig(version='lucid', architecture='x86_64', build_type='debug', graphics_type='gpu'), TestConfig(version='lucid', architecture='x86_64', build_type='release', graphics_type='cpu'), TestConfig(version='lucid', architecture='x86_64', build_type='release', graphics_type='gpu')]
Comment 6 Adam Barth 2011-10-12 11:23:59 PDT 
Created attachment 110711 [details]
Patch
Comment 7 Adam Barth 2011-10-12 11:29:25 PDT 
Comment on attachment 110711 [details]
Patch

Clearing flags on attachment: 110711

Committed r97279: <http://trac.webkit.org/changeset/97279>
Comment 8 Adam Barth 2011-10-12 11:29:29 PDT 
All reviewed patches have been landed.  Closing bug.