globalObjectPrototypeIsDOMWindow now relies on the difference in internal fields count between DOMWindow and WorkerContext. Would be better to use V8DOMWrapper::isWrapperOfType for determining the global object type.
Created attachment 110677 [details] Patch
Comment on attachment 110677 [details] Patch lgtm, the only concern if it regresses performance as instantiateV8Object may be hot on some benchmarks. Mind running against Dromaeo with and without this change just to be sure?
(In reply to comment #2) > (From update of attachment 110677 [details]) > lgtm, the only concern if it regresses performance as instantiateV8Object may be hot on some benchmarks. Mind running against Dromaeo with and without this change just to be sure? Without the patch: http://dromaeo.com/?id=152544 -- 1147.88runs/s (Total) With the patch applied: http://dromaeo.com/?id=152545 -- 1130.44runs/s (Total)
Committed r97260: <http://trac.webkit.org/changeset/97260>