Bug 69923 - [v8] Use V8DOMWrapper::isWrapperOfType for determining global object type
Summary: [v8] Use V8DOMWrapper::isWrapperOfType for determining global object type
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-12 06:14 PDT by Yury Semikhatsky
Modified: 2011-10-12 07:21 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.70 KB, patch)
2011-10-12 06:21 PDT, Yury Semikhatsky
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2011-10-12 06:14:49 PDT
globalObjectPrototypeIsDOMWindow now relies on the difference in internal fields count between DOMWindow and WorkerContext. Would be better to use V8DOMWrapper::isWrapperOfType for determining the global object type.
Comment 1 Yury Semikhatsky 2011-10-12 06:21:31 PDT
Created attachment 110677 [details]
Patch
Comment 2 anton muhin 2011-10-12 06:25:51 PDT
Comment on attachment 110677 [details]
Patch

lgtm, the only concern if it regresses performance as instantiateV8Object may be hot on some benchmarks.  Mind running against Dromaeo with and without this change just to be sure?
Comment 3 Yury Semikhatsky 2011-10-12 07:18:16 PDT
(In reply to comment #2)
> (From update of attachment 110677 [details])
> lgtm, the only concern if it regresses performance as instantiateV8Object may be hot on some benchmarks.  Mind running against Dromaeo with and without this change just to be sure?

Without the patch: http://dromaeo.com/?id=152544 -- 1147.88runs/s (Total)
With the patch applied:  http://dromaeo.com/?id=152545 -- 1130.44runs/s (Total)
Comment 4 Yury Semikhatsky 2011-10-12 07:21:52 PDT
Committed r97260: <http://trac.webkit.org/changeset/97260>