RESOLVED FIXED 69923
[v8] Use V8DOMWrapper::isWrapperOfType for determining global object type 
https://bugs.webkit.org/show_bug.cgi?id=69923
Summary [v8] Use V8DOMWrapper::isWrapperOfType for determining global object type
Yury Semikhatsky
Reported 2011-10-12 06:14:49 PDT
globalObjectPrototypeIsDOMWindow now relies on the difference in internal fields count between DOMWindow and WorkerContext. Would be better to use V8DOMWrapper::isWrapperOfType for determining the global object type.
Attachments
Patch (3.70 KB, patch)
2011-10-12 06:21 PDT, Yury Semikhatsky 		pfeldman: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2011-10-12 06:21:31 PDT
Created attachment 110677 [details] Patch
anton muhin
Comment 2 2011-10-12 06:25:51 PDT
Comment on attachment 110677 [details] Patch lgtm, the only concern if it regresses performance as instantiateV8Object may be hot on some benchmarks. Mind running against Dromaeo with and without this change just to be sure?
Yury Semikhatsky
Comment 3 2011-10-12 07:18:16 PDT
(In reply to comment #2) > (From update of attachment 110677 [details]) > lgtm, the only concern if it regresses performance as instantiateV8Object may be hot on some benchmarks. Mind running against Dromaeo with and without this change just to be sure? Without the patch: http://dromaeo.com/?id=152544 -- 1147.88runs/s (Total) With the patch applied: http://dromaeo.com/?id=152545 -- 1130.44runs/s (Total)
Yury Semikhatsky
Comment 4 2011-10-12 07:21:52 PDT
Committed r97260: <http://trac.webkit.org/changeset/97260>
Note You need to log in before you can comment on or make changes to this bug.