Bug 69920 - [Qt] [Symbian] Remove support for the Symbian platform for the QtWebKit port
Summary: [Qt] [Symbian] Remove support for the Symbian platform for the QtWebKit port
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-10-12 05:03 PDT by Laszlo Gombos
Modified: 2011-10-15 06:58 PDT (History)
3 users (show)

See Also:


Attachments
1st try (315.78 KB, patch)
2011-10-12 05:49 PDT, Laszlo Gombos
kenneth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Laszlo Gombos 2011-10-12 05:03:24 PDT
We no longer have plans to maintain the Symbian platform support for QtWebKit. In the interest of keeping the code clean and well maintained we should remove the Symbian specific code sections.
Comment 1 Laszlo Gombos 2011-10-12 05:49:20 PDT
Created attachment 110675 [details]
1st try
Comment 2 Kenneth Rohde Christiansen 2011-10-12 05:55:28 PDT
Comment on attachment 110675 [details]
1st try

rs=me! I guess maemo5 is next? :-)
Comment 3 Chang Shu 2011-10-12 06:10:12 PDT
I lost my patience to finish reading this extremely long patch. :) But I noticed some *-armcc sections have been removed from the pro files. Is armcc specific to symbian?
Comment 4 Kenneth Rohde Christiansen 2011-10-12 06:50:47 PDT
Comment on attachment 110675 [details]
1st try

View in context: https://bugs.webkit.org/attachment.cgi?id=110675&action=review

> Source/WebKit.pri:-112
> -symbian|*-armcc {
> -    # Enable GNU compiler extensions to the ARM compiler for all Qt ports using RVCT
> -    RVCT_COMMON_CFLAGS = --gnu --diag_suppress 68,111,177,368,830,1293
> -    RVCT_COMMON_CXXFLAGS = $$RVCT_COMMON_CFLAGS --no_parse_templates
> -    # Make debug symbols leaner in RVCT4.x. Ignored by compiler for release builds
> -    QMAKE_CXXFLAGS.ARMCC_4_0 += --remove_unneeded_entities
> -    # Match other compilers' (GCC, MSVC, WINSCW...) behavior regarding bitfield signedness.
> -    # This flag is not needed for RVCT 2.x.
> -    QMAKE_CXXFLAGS.ARMCC_4_0 += --signed_bitfields
> -}
> -
> -*-armcc {
> -    QMAKE_CFLAGS += $$RVCT_COMMON_CFLAGS
> -    QMAKE_CXXFLAGS += $$RVCT_COMMON_CXXFLAGS
> -}

Yeah I wonder about these as well.
Comment 5 Laszlo Gombos 2011-10-13 04:04:47 PDT
(In reply to comment #4)
> (From update of attachment 110675 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=110675&action=review
> 
> > Source/WebKit.pri:-112
> > -symbian|*-armcc {
> > -    # Enable GNU compiler extensions to the ARM compiler for all Qt ports using RVCT
> > -    RVCT_COMMON_CFLAGS = --gnu --diag_suppress 68,111,177,368,830,1293
> > -    RVCT_COMMON_CXXFLAGS = $$RVCT_COMMON_CFLAGS --no_parse_templates
> > -    # Make debug symbols leaner in RVCT4.x. Ignored by compiler for release builds
> > -    QMAKE_CXXFLAGS.ARMCC_4_0 += --remove_unneeded_entities
> > -    # Match other compilers' (GCC, MSVC, WINSCW...) behavior regarding bitfield signedness.
> > -    # This flag is not needed for RVCT 2.x.
> > -    QMAKE_CXXFLAGS.ARMCC_4_0 += --signed_bitfields
> > -}
> > -
> > -*-armcc {
> > -    QMAKE_CFLAGS += $$RVCT_COMMON_CFLAGS
> > -    QMAKE_CXXFLAGS += $$RVCT_COMMON_CXXFLAGS
> > -}
> 
> Yeah I wonder about these as well.

These are indeed not (just) symbian specific. In theory these are for any QtWebKit port/project using RVCT, but to my knowledge the only port/project using RVCT is the Symbian port so I deliberately removed it. We surely do not have a buildbot using RVCT other than Symbian.

COMPILER(RVCT) code sections are not removed as those are indeed shared with other non-Qt based ports, but the changes in the Qt make file are for the Qt port only.
Comment 6 Andreas Kling 2011-10-13 04:50:23 PDT
(In reply to comment #2)
> (From update of attachment 110675 [details])
> rs=me! I guess maemo5 is next? :-)

This is awesome. And that would be awesome, too!
Comment 7 Laszlo Gombos 2011-10-13 04:50:59 PDT
Link to related qtwebkit-dev announcement/discussion - https://lists.webkit.org/pipermail/webkit-qt/2011-October/001979.html .
Comment 8 Chang Shu 2011-10-13 06:43:15 PDT
Makes sense.
> 
> These are indeed not (just) symbian specific. In theory these are for any QtWebKit port/project using RVCT, but to my knowledge the only port/project using RVCT is the Symbian port so I deliberately removed it. We surely do not have a buildbot using RVCT other than Symbian.
> 
> COMPILER(RVCT) code sections are not removed as those are indeed shared with other non-Qt based ports, but the changes in the Qt make file are for the Qt port only.
Comment 9 Laszlo Gombos 2011-10-15 06:58:57 PDT
Landed as http://trac.webkit.org/changeset/97557. Closing bug.