RESOLVED FIXED 69918
DFG JIT 32_64 - Fix ArrayPop 
https://bugs.webkit.org/show_bug.cgi?id=69918
Summary DFG JIT 32_64 - Fix ArrayPop
Yuqiang Xian
Reported 2011-10-12 04:01:10 PDT
The storageLengthGPR is polluted by EmptyValueTag and later used to index the array, which results in abnormal behaviors in execution. This fix makes 32_64 DFG pass v8-deltablue and kraken crypto-sha256-iterative on Linux ia32.
Attachments
the patch (2.04 KB, patch)
2011-10-12 04:03 PDT, Yuqiang Xian 		no flags
DetailsFormatted DiffDiff
the patch (3.47 KB, patch)
2011-10-12 05:33 PDT, Yuqiang Xian 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yuqiang Xian
Comment 1 2011-10-12 04:03:54 PDT
Created attachment 110662 [details] the patch
Yuqiang Xian
Comment 2 2011-10-12 05:33:30 PDT
Created attachment 110672 [details] the patch I think I was muddled when developing the previous wrong patch... :( Also, please help land it manually if you think it should be r+, as I'm not sure if the commit queue will be happy about the style warnings. Thanks a lot.
WebKit Review Bot
Comment 3 2011-10-12 05:36:19 PDT
Attachment 110672 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/assembler/X86Assembler.h:1069: movl_i32m is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.
Filip Pizlo
Comment 4 2011-10-12 11:36:01 PDT
Ouch, I can't believe I created that bug.
WebKit Review Bot
Comment 5 2011-10-12 12:27:18 PDT
Comment on attachment 110672 [details] the patch Clearing flags on attachment: 110672 Committed r97286: <http://trac.webkit.org/changeset/97286>
WebKit Review Bot
Comment 6 2011-10-12 12:27:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.