Bug 69907 – Implement an OverflowEvent constructor for JSC

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Kentaro Hara]

We have been implementing constructors of Events. OverflowEvent should have a constructor. 

There is no spec for the OverflowEvent constructor, since it is WebKit-specific. Judging from the current IDL of initOverflowEvent(), the IDL of the OveflowEvent constructor should be as follows.

[Constructor(DOMString type, optional OverflowEventInit eventInitDict)]
interface OverflowEvent : Event {
    ...;
}

dictionary OverflowEventInit : EventInit {
    unsigned short orient;
    boolean horizontalOverflow;
    boolean verticalOverflow;
}

[Kentaro Hara]

Created attachment 110650 [details]
Patch

[WebKit Review Bot]

Comment on attachment 110650 [details]
Patch

Attachment 110650 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10032646

New failing tests:
fast/dom/dom-constructors.html

[Kentaro Hara]

Created attachment 110682 [details]
Patch

[Adam Barth]

Comment on attachment 110682 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110682&action=review

> Source/WebCore/dom/OverflowEvent.idl:26
>   */
>  module events {
> -    interface OverflowEvent : Event {
> +    interface [

We could add some blank lines between the license block, the module, and the interface declaration.  (If you wanted to.)

[Kentaro Hara]

Created attachment 110808 [details]
rebased patch for commit

[WebKit Review Bot]

Comment on attachment 110808 [details]
rebased patch for commit

Clearing flags on attachment: 110808

Committed r97356: <http://trac.webkit.org/changeset/97356>