Bug 69907 - Implement an OverflowEvent constructor for JSC
Summary: Implement an OverflowEvent constructor for JSC
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 67824
  Show dependency treegraph
Reported: 2011-10-12 00:01 PDT by Kentaro Hara
Modified: 2011-10-13 04:37 PDT (History)
6 users (show)

See Also:

Patch (20.84 KB, patch)
2011-10-12 00:59 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff
Patch (22.56 KB, patch)
2011-10-12 07:18 PDT, Kentaro Hara
abarth: review+
Details | Formatted Diff | Diff
rebased patch for commit (22.75 KB, patch)
2011-10-13 00:56 PDT, Kentaro Hara
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kentaro Hara 2011-10-12 00:01:57 PDT
We have been implementing constructors of Events. OverflowEvent should have a constructor. 

There is no spec for the OverflowEvent constructor, since it is WebKit-specific. Judging from the current IDL of initOverflowEvent(), the IDL of the OveflowEvent constructor should be as follows.

[Constructor(DOMString type, optional OverflowEventInit eventInitDict)]
interface OverflowEvent : Event {

dictionary OverflowEventInit : EventInit {
    unsigned short orient;
    boolean horizontalOverflow;
    boolean verticalOverflow;
Comment 1 Kentaro Hara 2011-10-12 00:59:04 PDT
Created attachment 110650 [details]
Comment 2 WebKit Review Bot 2011-10-12 03:29:09 PDT
Comment on attachment 110650 [details]

Attachment 110650 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10032646

New failing tests:
Comment 3 Kentaro Hara 2011-10-12 07:18:43 PDT
Created attachment 110682 [details]
Comment 4 Adam Barth 2011-10-12 09:49:36 PDT
Comment on attachment 110682 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=110682&action=review

> Source/WebCore/dom/OverflowEvent.idl:26
>   */
>  module events {
> -    interface OverflowEvent : Event {
> +    interface [

We could add some blank lines between the license block, the module, and the interface declaration.  (If you wanted to.)
Comment 5 Kentaro Hara 2011-10-13 00:56:53 PDT
Created attachment 110808 [details]
rebased patch for commit
Comment 6 WebKit Review Bot 2011-10-13 02:12:55 PDT
Comment on attachment 110808 [details]
rebased patch for commit

Clearing flags on attachment: 110808

Committed r97356: <http://trac.webkit.org/changeset/97356>