Bug 69903 - DFG 32_64 - fix silentFillGPR
Summary: DFG 32_64 - fix silentFillGPR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-11 22:43 PDT by Yuqiang Xian
Modified: 2011-10-11 23:11 PDT (History)
3 users (show)

See Also:


Attachments
the patch (1.82 KB, patch)
2011-10-11 22:45 PDT, Yuqiang Xian
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuqiang Xian 2011-10-11 22:43:22 PDT
Fix a small bug in silentFillGPR, and add the newly added DFG file to CMakeListsEfl.
Comment 1 Yuqiang Xian 2011-10-11 22:45:53 PDT
Created attachment 110638 [details]
the patch
Comment 2 WebKit Review Bot 2011-10-11 23:04:54 PDT
Comment on attachment 110638 [details]
the patch

Clearing flags on attachment: 110638

Committed r97234: <http://trac.webkit.org/changeset/97234>
Comment 3 WebKit Review Bot 2011-10-11 23:04:59 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Gavin Barraclough 2011-10-11 23:11:11 PDT
Good catch! - but the silentFillGPR changes have been reverted in r97235 due to bug #69897 (I caused ASSERTs in the JSVALUE64 path, I'll have to investigate), when I re-land I'll make sure to incorporate your fix.

cheers,
G.