Bug 69896 - [CSS Regions] Make positioned blocks work with variable width regions.
Summary: [CSS Regions] Make positioned blocks work with variable width regions.
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dave Hyatt
Depends on:
Blocks: 57312
  Show dependency treegraph
Reported: 2011-10-11 21:21 PDT by Dave Hyatt
Modified: 2012-07-23 23:30 PDT (History)
3 users (show)

See Also:

Patch (327.41 KB, patch)
2011-10-11 21:41 PDT, Dave Hyatt
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Patch (327.41 KB, patch)
2011-10-11 22:04 PDT, Dave Hyatt
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2011-10-11 21:21:06 PDT
Make positioned blocks work with variable width regions. This means the offsets and widths actually compute independently in each region if needed.
Comment 1 Dave Hyatt 2011-10-11 21:41:12 PDT
Created attachment 110634 [details]
Comment 2 WebKit Review Bot 2011-10-11 21:45:04 PDT
Attachment 110634 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1

Source/WebCore/rendering/LayoutState.cpp:97:  Should have only a single space after a punctuation in a comment.  [whitespace/comments] [5]
Source/WebCore/rendering/RenderBox.h:469:  The parameter name "region" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 29 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Review Bot 2011-10-11 21:53:22 PDT
Comment on attachment 110634 [details]

Attachment 110634 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/10031662
Comment 4 Dave Hyatt 2011-10-11 22:04:05 PDT
Created attachment 110635 [details]
Comment 5 Dave Hyatt 2011-10-12 11:50:36 PDT
Fixed in 97282.