Bug 69895 - REGRESSION(r89915): <input type=email multiple> don't show the default value
Summary: REGRESSION(r89915): <input type=email multiple> don't show the default value
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Major
Assignee: Kent Tamura
URL:
Keywords: Regression
Depends on:
Blocks:
 
Reported: 2011-10-11 20:42 PDT by Kent Tamura
Modified: 2011-10-13 00:34 PDT (History)
1 user (show)

See Also:


Attachments
Patch (4.92 KB, patch)
2011-10-11 20:58 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff
Patch 2 (13.52 KB, patch)
2011-10-11 23:17 PDT, Kent Tamura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Kent Tamura 2011-10-11 20:58:53 PDT
Created attachment 110631 [details]
Patch
Comment 2 Hajime Morrita 2011-10-11 22:31:25 PDT
Comment on attachment 110631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110631&action=review

> Source/WebCore/html/EmailInputType.cpp:95
>  String EmailInputType::sanitizeValue(const String& proposedValue)

I noticed that InptType::sanitizeValue() is virtual and it's indirected by HTMLInputElement::sanitizeValue().
So I hope this kind of guard is inside HTMLInputElement instead each InputType subclasses and 
allow InputType assume this as a invariant.
Also, I hope sanitizeValue() to be const.
Comment 3 Kent Tamura 2011-10-11 23:17:39 PDT
Created attachment 110642 [details]
Patch 2
Comment 4 Kent Tamura 2011-10-11 23:18:02 PDT
Comment on attachment 110631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=110631&action=review

>> Source/WebCore/html/EmailInputType.cpp:95
>>  String EmailInputType::sanitizeValue(const String& proposedValue)
> 
> I noticed that InptType::sanitizeValue() is virtual and it's indirected by HTMLInputElement::sanitizeValue().
> So I hope this kind of guard is inside HTMLInputElement instead each InputType subclasses and 
> allow InputType assume this as a invariant.
> Also, I hope sanitizeValue() to be const.

Fixed.
Comment 5 Kent Tamura 2011-10-13 00:34:02 PDT
Comment on attachment 110642 [details]
Patch 2

Clearing flags on attachment: 110642

Committed r97351: <http://trac.webkit.org/changeset/97351>
Comment 6 Kent Tamura 2011-10-13 00:34:08 PDT
All reviewed patches have been landed.  Closing bug.