WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
69895
REGRESSION(
r89915
): <input type=email multiple> don't show the default value
https://bugs.webkit.org/show_bug.cgi?id=69895
Summary
REGRESSION(r89915): <input type=email multiple> don't show the default value
Kent Tamura
Reported
2011-10-11 20:42:04 PDT
http://code.google.com/p/chromium/issues/detail?id=99829
Attachments
Patch
(4.92 KB, patch)
2011-10-11 20:58 PDT
,
Kent Tamura
no flags
Details
Formatted Diff
Diff
Patch 2
(13.52 KB, patch)
2011-10-11 23:17 PDT
,
Kent Tamura
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Kent Tamura
Comment 1
2011-10-11 20:58:53 PDT
Created
attachment 110631
[details]
Patch
Hajime Morrita
Comment 2
2011-10-11 22:31:25 PDT
Comment on
attachment 110631
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=110631&action=review
> Source/WebCore/html/EmailInputType.cpp:95 > String EmailInputType::sanitizeValue(const String& proposedValue)
I noticed that InptType::sanitizeValue() is virtual and it's indirected by HTMLInputElement::sanitizeValue(). So I hope this kind of guard is inside HTMLInputElement instead each InputType subclasses and allow InputType assume this as a invariant. Also, I hope sanitizeValue() to be const.
Kent Tamura
Comment 3
2011-10-11 23:17:39 PDT
Created
attachment 110642
[details]
Patch 2
Kent Tamura
Comment 4
2011-10-11 23:18:02 PDT
Comment on
attachment 110631
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=110631&action=review
>> Source/WebCore/html/EmailInputType.cpp:95 >> String EmailInputType::sanitizeValue(const String& proposedValue) > > I noticed that InptType::sanitizeValue() is virtual and it's indirected by HTMLInputElement::sanitizeValue(). > So I hope this kind of guard is inside HTMLInputElement instead each InputType subclasses and > allow InputType assume this as a invariant. > Also, I hope sanitizeValue() to be const.
Fixed.
Kent Tamura
Comment 5
2011-10-13 00:34:02 PDT
Comment on
attachment 110642
[details]
Patch 2 Clearing flags on attachment: 110642 Committed
r97351
: <
http://trac.webkit.org/changeset/97351
>
Kent Tamura
Comment 6
2011-10-13 00:34:08 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug