Some functions in EditingStyle are exposed globally because of selectionStartStyle and selectionHasStyle. We should move these functions to EditingStyle to better encapsulate style-related editing functions.
Created attachment 110713 [details] cleanup
Created attachment 110714 [details] Fixed changelog
Comment on attachment 110714 [details] Fixed changelog View in context: https://bugs.webkit.org/attachment.cgi?id=110714&action=review > Source/WebCore/editing/Editor.cpp:557 > +#endif I thought you wanted to move this to EditorMac. Why did you change your mind? > Source/WebCore/editing/Editor.cpp:2833 > +#endif Ditto.
Comment on attachment 110714 [details] Fixed changelog View in context: https://bugs.webkit.org/attachment.cgi?id=110714&action=review >> Source/WebCore/editing/Editor.cpp:557 >> +#endif > > I thought you wanted to move this to EditorMac. Why did you change your mind? That'll be done in a follow up patch :) These functions are exported to WebKit layer and updating symbols and all is a bit troublesome since this patch is already pretty big.
Comment on attachment 110714 [details] Fixed changelog Thanks for the explanation. Looks good to me.
(In reply to comment #5) > (From update of attachment 110714 [details]) > Thanks for the explanation. Looks good to me. Great! Filed the bug 70114 to move the said functions to EditorMac.
Comment on attachment 110714 [details] Fixed changelog Clearing flags on attachment: 110714 Committed r97480: <http://trac.webkit.org/changeset/97480>
All reviewed patches have been landed. Closing bug.