Bug 69882 - Move selectionStartStyle and selectionHasStyle to EditingStyle
Summary: Move selectionStartStyle and selectionHasStyle to EditingStyle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 54932 70114
  Show dependency treegraph
 
Reported: 2011-10-11 16:53 PDT by Ryosuke Niwa
Modified: 2011-10-14 10:59 PDT (History)
6 users (show)

See Also:


Attachments
cleanup (24.95 KB, patch)
2011-10-12 11:41 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Fixed changelog (23.96 KB, patch)
2011-10-12 11:42 PDT, Ryosuke Niwa
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-10-11 16:53:41 PDT
Some functions in EditingStyle are exposed globally because of selectionStartStyle and selectionHasStyle. We should move these functions to EditingStyle to better encapsulate style-related editing functions.
Comment 1 Ryosuke Niwa 2011-10-12 11:41:38 PDT
Created attachment 110713 [details]
cleanup
Comment 2 Ryosuke Niwa 2011-10-12 11:42:30 PDT
Created attachment 110714 [details]
Fixed changelog
Comment 3 Enrica Casucci 2011-10-13 10:22:25 PDT
Comment on attachment 110714 [details]
Fixed changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=110714&action=review

> Source/WebCore/editing/Editor.cpp:557
> +#endif

I thought you wanted to move this to EditorMac. Why did you change your mind?

> Source/WebCore/editing/Editor.cpp:2833
> +#endif

Ditto.
Comment 4 Ryosuke Niwa 2011-10-13 10:42:57 PDT
Comment on attachment 110714 [details]
Fixed changelog

View in context: https://bugs.webkit.org/attachment.cgi?id=110714&action=review

>> Source/WebCore/editing/Editor.cpp:557
>> +#endif
> 
> I thought you wanted to move this to EditorMac. Why did you change your mind?

That'll be done in a follow up patch :) These functions are exported to WebKit layer and updating symbols and all is a bit troublesome since this patch is already pretty big.
Comment 5 Enrica Casucci 2011-10-14 09:51:48 PDT
Comment on attachment 110714 [details]
Fixed changelog

Thanks for the explanation. Looks good to me.
Comment 6 Ryosuke Niwa 2011-10-14 09:55:42 PDT
(In reply to comment #5)
> (From update of attachment 110714 [details])
> Thanks for the explanation. Looks good to me.

Great! Filed the bug 70114 to move the said functions to EditorMac.
Comment 7 Ryosuke Niwa 2011-10-14 10:59:30 PDT
Comment on attachment 110714 [details]
Fixed changelog

Clearing flags on attachment: 110714

Committed r97480: <http://trac.webkit.org/changeset/97480>
Comment 8 Ryosuke Niwa 2011-10-14 10:59:33 PDT
All reviewed patches have been landed.  Closing bug.