RESOLVED FIXED 69874
WebKit2 snapshot APIs should take the device scale factor into account 
https://bugs.webkit.org/show_bug.cgi?id=69874
Summary WebKit2 snapshot APIs should take the device scale factor into account
Beth Dakin
Reported 2011-10-11 15:27:10 PDT
WebKit2 snapshot APIs should take the device scale factor into account to create snapshots at the appropriate resolution.
Attachments
Patch (2.83 KB, patch)
2011-10-11 15:42 PDT, Beth Dakin 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Beth Dakin
Comment 1 2011-10-11 15:42:14 PDT
Created attachment 110591 [details] Patch
Darin Adler
Comment 2 2011-10-11 15:45:31 PDT
Comment on attachment 110591 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=110591&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:945 > + float deviceScaleFactor = corePage()->deviceScaleFactor(); Given that the code below repeatedly multiplies this by the scale factor and never uses the device scale factor alone, I’d suggest instead: float combinedScaleFactor = scaleFactor * corePage()->deviceScaleFactor();
Beth Dakin
Comment 3 2011-10-11 16:04:51 PDT
(In reply to comment #2) > (From update of attachment 110591 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=110591&action=review > > > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:945 > > + float deviceScaleFactor = corePage()->deviceScaleFactor(); > > Given that the code below repeatedly multiplies this by the scale factor and never uses the device scale factor alone, I’d suggest instead: > > float combinedScaleFactor = scaleFactor * corePage()->deviceScaleFactor(); Fixed! Thanks! Change committed with revision 97191.
Note You need to log in before you can comment on or make changes to this bug.