Bug 69857 - Web Inspector: The "x" in "980px x 36px" looks weird in the inspector node callout
Summary: Web Inspector: The "x" in "980px x 36px" looks weird in the inspector node ca...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Alexander Pavlov (apavlov)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-11 11:43 PDT by Matt Lilek
Modified: 2011-10-20 01:15 PDT (History)
10 users (show)

See Also:


Attachments
Screenshot (4.91 KB, image/png)
2011-10-11 11:43 PDT, Matt Lilek
no flags Details
[PATCH] Suggested fix (4.00 KB, patch)
2011-10-19 07:52 PDT, Alexander Pavlov (apavlov)
pfeldman: review+
Details | Formatted Diff | Diff
[IMAGE] Screenshot of the tooltip with the patch applied (8.73 KB, image/png)
2011-10-19 07:57 PDT, Alexander Pavlov (apavlov)
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Lilek 2011-10-11 11:43:06 PDT
It looks like units have recently been added to the dimensions shown in the inspector's node highlight callout - cool!  But the "x" that separates the two values blends in too much with the "px" on the first value.  See the attached screenshot.

Can the units used ever differ between the two values (i.e.: can something ever be 3em x 41px)?  If they can't, could we perhaps just list the unit once?  Perhaps something like "980 x 36px"?  Or "980 x 36 (px)"?
Comment 1 Matt Lilek 2011-10-11 11:43:22 PDT
Created attachment 110549 [details]
Screenshot
Comment 2 Alexander Pavlov (apavlov) 2011-10-19 07:52:44 PDT
Created attachment 111618 [details]
[PATCH] Suggested fix
Comment 3 Alexander Pavlov (apavlov) 2011-10-19 07:57:30 PDT
Created attachment 111620 [details]
[IMAGE] Screenshot of the tooltip with the patch applied

Spaces have been added around the "times" sign (previously there were none), as suggested by pfeldman@chromium.org. Having the "px" only once in the string looks somewhat unbalanced.
Comment 4 Alexander Pavlov (apavlov) 2011-10-20 01:15:00 PDT
Committed r97949: <http://trac.webkit.org/changeset/97949>