Bug 69855 - [Chromium] Prevent fallback fonts from purging while measuring
Summary: [Chromium] Prevent fallback fonts from purging while measuring
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Cary Clark
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-11 11:25 PDT by Cary Clark
Modified: 2011-10-12 06:30 PDT (History)
7 users (show)

See Also:

Attachments
Patch (1.89 KB, patch)
2011-10-11 11:29 PDT, Cary Clark 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cary Clark 2011-10-11 11:25:11 PDT 
[Chromium] Prevent fallback fonts from purging while measuring
Comment 1 Cary Clark 2011-10-11 11:29:15 PDT 
Created attachment 110546 [details]
Patch
Comment 2 Cary Clark 2011-10-11 11:32:12 PDT 
obsoleted 69843 that did the same thing in the wrong place
Comment 3 Stephen White 2011-10-11 11:40:48 PDT 
Comment on attachment 110546 [details]
Patch

This looks reasonable to me, but it's kind of beyond my expertise.  Eric, could you take a look?
Comment 4 Eric Seidel (no email) 2011-10-11 12:14:22 PDT 
msaboff@apple.com added the original, I see you've CC'd him.

Hyatt has historically done the most font-related work, I assume msaboff consulted him in this as well.  Brett also did a lot of the font-related bringup for chome.

It feels very strange to me that we would need to do this at the WebKit layer like this.

It does appear that this is how this object is typically used however, so r+.
Comment 5 WebKit Review Bot 2011-10-12 06:30:11 PDT 
Comment on attachment 110546 [details]
Patch

Clearing flags on attachment: 110546

Committed r97257: <http://trac.webkit.org/changeset/97257>
Comment 6 WebKit Review Bot 2011-10-12 06:30:16 PDT 
All reviewed patches have been landed.  Closing bug.