Bug 69833 - Web Inspector: make Extensions component compile.
Summary: Web Inspector: make Extensions component compile.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Pavel Feldman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-11 06:17 PDT by Pavel Feldman
Modified: 2011-10-11 07:42 PDT (History)
10 users (show)

See Also:

Attachments
Patch (24.17 KB, patch)
2011-10-11 06:21 PDT, Pavel Feldman 		no flags Details | Formatted Diff | Diff
[Patch] Same with settings screen and test controller (26.20 KB, patch)
2011-10-11 06:28 PDT, Pavel Feldman 		yurys: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Feldman 2011-10-11 06:17:12 PDT 
Patch to follow.
Comment 1 Pavel Feldman 2011-10-11 06:21:19 PDT 
Created attachment 110508 [details]
Patch
Comment 2 Pavel Feldman 2011-10-11 06:28:06 PDT 
Created attachment 110509 [details]
[Patch] Same with settings screen and test controller
Comment 3 Yury Semikhatsky 2011-10-11 06:44:27 PDT 
Comment on attachment 110509 [details]
[Patch] Same with settings screen and test controller

View in context: https://bugs.webkit.org/attachment.cgi?id=110509&action=review

> Source/WebCore/inspector/front-end/TestController.js:-50
> -                result = window[script].call(WebInspector, controller);

Please make sure this code is not used.
Comment 4 Andrey Kosyakov 2011-10-11 06:52:58 PDT 
Comment on attachment 110509 [details]
[Patch] Same with settings screen and test controller

View in context: https://bugs.webkit.org/attachment.cgi?id=110509&action=review

> Source/WebCore/inspector/front-end/ExtensionAPI.js:-383
> -    createResult: function()

This is an API method, this will break extension API interface.
Comment 5 Pavel Feldman 2011-10-11 07:42:55 PDT 
Committed r97152: <http://trac.webkit.org/changeset/97152>