RESOLVED FIXED 69833
Web Inspector: make Extensions component compile. 
https://bugs.webkit.org/show_bug.cgi?id=69833
Summary Web Inspector: make Extensions component compile.
Pavel Feldman
Reported 2011-10-11 06:17:12 PDT
Patch to follow.
Attachments
Patch (24.17 KB, patch)
2011-10-11 06:21 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
[Patch] Same with settings screen and test controller (26.20 KB, patch)
2011-10-11 06:28 PDT, Pavel Feldman 		yurys: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-10-11 06:21:19 PDT
Created attachment 110508 [details] Patch
Pavel Feldman
Comment 2 2011-10-11 06:28:06 PDT
Created attachment 110509 [details] [Patch] Same with settings screen and test controller
Yury Semikhatsky
Comment 3 2011-10-11 06:44:27 PDT
Comment on attachment 110509 [details] [Patch] Same with settings screen and test controller View in context: https://bugs.webkit.org/attachment.cgi?id=110509&action=review > Source/WebCore/inspector/front-end/TestController.js:-50 > - result = window[script].call(WebInspector, controller); Please make sure this code is not used.
Andrey Kosyakov
Comment 4 2011-10-11 06:52:58 PDT
Comment on attachment 110509 [details] [Patch] Same with settings screen and test controller View in context: https://bugs.webkit.org/attachment.cgi?id=110509&action=review > Source/WebCore/inspector/front-end/ExtensionAPI.js:-383 > - createResult: function() This is an API method, this will break extension API interface.
Pavel Feldman
Comment 5 2011-10-11 07:42:55 PDT
Committed r97152: <http://trac.webkit.org/changeset/97152>
Note You need to log in before you can comment on or make changes to this bug.