Bug 69823 - [GTK] Add can_go_back/forward methods to WebKit2 GTK+ API
Summary: [GTK] Add can_go_back/forward methods to WebKit2 GTK+ API
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Blocks: 69343
  Show dependency treegraph
Reported: 2011-10-11 01:51 PDT by Carlos Garcia Campos
Modified: 2011-10-21 01:16 PDT (History)
3 users (show)

See Also:

Patch (3.24 KB, patch)
2011-10-11 01:53 PDT, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2011-10-11 01:51:45 PDT
Add webkit_web_view_can_go_back() and webkit_web_view_can_go_forward()
Comment 1 Carlos Garcia Campos 2011-10-11 01:53:46 PDT
Created attachment 110486 [details]
Comment 2 Carlos Garcia Campos 2011-10-11 02:06:25 PDT
I'll add unit tests for these methods to the backforwardlist test once bug #69343 is fixed.
Comment 3 Martin Robinson 2011-10-20 22:57:47 PDT
Comment on attachment 110486 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=110486&action=review

This looks good to me!

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:303
> + * Returns: %TRUE if able to move back, %FALSE otherwise.

, -> or

(based on our previous conversation)

> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:333
> + * Returns: %TRUE if able to move forward, %FALSE otherwise.

Comment 4 Carlos Garcia Campos 2011-10-21 01:16:16 PDT
Committed r98081: <http://trac.webkit.org/changeset/98081>