WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
69823
[GTK] Add can_go_back/forward methods to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69823
Summary
[GTK] Add can_go_back/forward methods to WebKit2 GTK+ API
Carlos Garcia Campos
Reported
2011-10-11 01:51:45 PDT
Add webkit_web_view_can_go_back() and webkit_web_view_can_go_forward()
Attachments
Patch
(3.24 KB, patch)
2011-10-11 01:53 PDT
,
Carlos Garcia Campos
mrobinson
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1
2011-10-11 01:53:46 PDT
Created
attachment 110486
[details]
Patch
Carlos Garcia Campos
Comment 2
2011-10-11 02:06:25 PDT
I'll add unit tests for these methods to the backforwardlist test once
bug #69343
is fixed.
Martin Robinson
Comment 3
2011-10-20 22:57:47 PDT
Comment on
attachment 110486
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=110486&action=review
This looks good to me!
> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:303 > + * Returns: %TRUE if able to move back, %FALSE otherwise.
, -> or (based on our previous conversation)
> Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:333 > + * Returns: %TRUE if able to move forward, %FALSE otherwise.
Ditto.
Carlos Garcia Campos
Comment 4
2011-10-21 01:16:16 PDT
Committed
r98081
: <
http://trac.webkit.org/changeset/98081
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug