Bug 69819 – [Mac] Draw glyphs with their original matrix and font size

• Status: RESOLVED
• Resolution: INVALID
• Component: Layout and Rendering

[Benjamin Poulain]

Currently, the font matrix is applied scaled to the font size in some cases. In those cases, the font size is set to 1.0 to avoid setting font the size twice, and the text is rendered.

If I understand this thing correctly, it would be simpler to apply the base matrix and set the font size in all cases. This would make the code simpler and hopefully a bit more effective.

[Benjamin Poulain]

Created attachment 110480 [details]
Patch

[Darin Adler]

Comment on attachment 110480 [details]
Patch

This looks like it could change the behavior for color bitmap fonts.

[Darin Adler]

If the only benefit of this change is more elegance, and this doesn’t fix any bugs, then we should be doubly sure this doesn’t create any problems.

[Benjamin Poulain]

Comment on attachment 110480 [details]
Patch

(In reply to comment #3)
> If the only benefit of this change is more elegance, and this doesn’t fix any bugs, then we should be doubly sure this doesn’t create any problems.

I was also looking into using more CoreText instead of NSFont in order to have more code shared with iOS.

> This looks like it could change the behavior for color bitmap fonts.

I clear the review flag for now. I'll test specifically bitmap fonts next weekend.

[Benjamin Poulain]

Bitmap fonts are fine with this patch.

However, I see third party can potentially override WebFontCache. In this case, the third party could return a font that is not actually of the requested size, which would break with this patch.

Closing, that is not worth the risk.