Bug 69816 - REGRESSION (WebKit2): Document marker added by find looks odd when found text is split by inline elements
Summary: REGRESSION (WebKit2): Document marker added by find looks odd when found text...
Status: RESOLVED DUPLICATE of bug 75220
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-10 22:22 PDT by Ryosuke Niwa
Modified: 2011-12-25 21:25 PST (History)
8 users (show)

See Also:

Attachments
screenshot (29.40 KB, image/png)
2011-10-10 22:22 PDT, Ryosuke Niwa 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-10-10 22:22:29 PDT 
Created attachment 110475 [details]
screenshot

Reproduction steps
1. Open https://bugs.webkit.org/attachment.cgi?id=110462&action=review on ToT WebKit
2. Search for "recalcListItemsInternal"

Expected result:
Every instance of "recalcListItemsInternal" is highlighted properly

Actual result:
Some instances of "recalcListItemsInternal" are highlighted by chunks of document markers.
Comment 2 Hajime Morrita 2011-10-12 02:10:32 PDT 
It looks markers are actually splited because each marker is associated to a text node, not to a range.
I guess its design haven't changed from beginning. 
But something is apparently wrong.  

The problem is that WebKit2(safari) paint textmatch marker hightlight to animate it.
(Other ports seem to use InlineTextBox::paintTextMatchMarker(), a non-animated version.)
I have no idea what type of fix is good for the Safari's implementation.
Comment 3 Alexey Proskuryakov 2011-10-12 08:30:24 PDT 
Why did you remove "REGRESSION (WebKit2)" prefix from the title? This is a regression from WK1 to WK2.
Comment 4 Alexey Proskuryakov 2011-12-25 21:23:48 PST 
Sounds like this got fixed today.

*** This bug has been marked as a duplicate of bug 75220 ***
Comment 5 mitz 2011-12-25 21:25:49 PST 
Sorry, everyone, I did not know about this bug before I filed bug 752220.