WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
69810
Rename getOwnPropertySlot to getOwnPropertySlotVirtual
https://bugs.webkit.org/show_bug.cgi?id=69810
Summary
Rename getOwnPropertySlot to getOwnPropertySlotVirtual
Mark Hahnenberg
Reported
2011-10-10 18:55:43 PDT
The compiler gets confused when we try to put getOwnPropertySlot into the method table when there is both a virtual and static version of the method (but it doesn't get confused when there are two static methods with different types). Therefore, we need to temporarily rename the virtual version of getOwnPropertySlot to getOwnPropertySlotVirtual. This will avoid the conflict later on when we add getOwnPropertySlot to the MethodTable in ClassInfo.
Attachments
Patch
(138.51 KB, patch)
2011-10-10 19:47 PDT
,
Mark Hahnenberg
no flags
Details
Formatted Diff
Diff
Patch
(138.58 KB, patch)
2011-10-10 19:56 PDT
,
Mark Hahnenberg
no flags
Details
Formatted Diff
Diff
Reset bindings
(170.41 KB, patch)
2011-10-10 20:10 PDT
,
Mark Hahnenberg
no flags
Details
Formatted Diff
Diff
Fix windows
(164.23 KB, patch)
2011-10-11 10:32 PDT
,
Mark Hahnenberg
no flags
Details
Formatted Diff
Diff
Fix windows
(164.60 KB, patch)
2011-10-11 14:08 PDT
,
Mark Hahnenberg
no flags
Details
Formatted Diff
Diff
Patch
(164.81 KB, patch)
2011-10-13 10:37 PDT
,
Mark Hahnenberg
no flags
Details
Formatted Diff
Diff
Patch
(164.91 KB, patch)
2011-10-14 11:42 PDT
,
Mark Hahnenberg
no flags
Details
Formatted Diff
Diff
Show Obsolete
(6)
View All
Add attachment
proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1
2011-10-10 19:47:12 PDT
Created
attachment 110461
[details]
Patch
Mark Hahnenberg
Comment 2
2011-10-10 19:56:24 PDT
Created
attachment 110464
[details]
Patch
Mark Hahnenberg
Comment 3
2011-10-10 20:10:52 PDT
Created
attachment 110466
[details]
Reset bindings
Mark Hahnenberg
Comment 4
2011-10-11 10:32:03 PDT
Created
attachment 110534
[details]
Fix windows
Mark Hahnenberg
Comment 5
2011-10-11 14:08:21 PDT
Created
attachment 110573
[details]
Fix windows
Mark Hahnenberg
Comment 6
2011-10-13 10:37:22 PDT
Created
attachment 110874
[details]
Patch
Geoffrey Garen
Comment 7
2011-10-14 11:14:41 PDT
Comment on
attachment 110874
[details]
Patch rs=me if it builds
Mark Hahnenberg
Comment 8
2011-10-14 11:42:49 PDT
Created
attachment 111036
[details]
Patch
Mark Hahnenberg
Comment 9
2011-10-14 18:59:39 PDT
Committed
r97537
: <
http://trac.webkit.org/changeset/97537
>
Daniel Bates
Comment 10
2011-10-15 13:09:23 PDT
This patch broke the Apple Windows build: <
http://build.webkit.org/builders/Windows%20Release%20%28Build%29/builds/22163/steps/compile-webkit/logs/stdio
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug